Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][UR] Bump UR version and add missing values to pi2ur #10049

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

callumfare
Copy link
Contributor

@callumfare callumfare commented Jun 23, 2023

Includes a large number of missing pi_result mappings, so previously reported errors should no longer map to just PI_ERROR_UNKNOWN. NFCI for the adapters.

Also add handle as many values as possible in pi_result -> ur_result_t conversion
@callumfare callumfare requested review from a team as code owners June 23, 2023 12:53
@callumfare callumfare requested a review from jchlanda June 23, 2023 12:53
@callumfare callumfare temporarily deployed to aws June 23, 2023 13:14 — with GitHub Actions Inactive
ur_kernel_handle_t hKernel, uint32_t argIndex, size_t argSize,
const ur_kernel_arg_value_properties_t *pProperties,
const void *pArgValue) {
std::ignore = pProperties;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@jandres742
Copy link
Contributor

Failure on Gen9 is with OpenCL, not L0. @callumfare patch doesn't touch anything related to OpenCL, so this seems something flaky.

$ ":" "RUN: at line 6"
note: command had no output on stdout or stderr
$ "env" "ONEAPI_DEVICE_SELECTOR=ext_oneapi_level_zero:gpu" "/__w/llvm/llvm/build-e2e/Regression/commandlist/Output/gpu.cpp.tmp.out"
# command output:
NThreads: GPU 8
   shared Queue: true
   array size: 1048576 (1<<20)
   SyCL items: 1048576
   iter GPU:   200
selected dev: Intel(R) UHD Graphics


                           subm   strt    end    run
GPU[1]:  nPrimes: 82024    0.00   0.20   2.87   2.66      0.00   2.88   2.88
GPU[6]:  nPrimes: 82024    2.88   2.87   5.52   2.65      0.01   5.55   5.54
GPU[5]:  nPrimes: 82024    5.55   5.52   8.17   2.65      0.01   8.21   8.19
GPU[2]:  nPrimes: 82024    8.21   8.17  10.81   2.64      0.01  10.86  10.85
GPU[4]:  nPrimes: 82024   10.86  10.82  13.47   2.65      0.01  13.52  13.51
GPU[3]:  nPrimes: 82024   13.52  13.47  16.37   2.90      0.01  16.43  16.42
GPU[7]:  nPrimes: 82024   16.43  16.37  19.07   2.71      0.01  19.15  19.14
GPU[0]:  nPrimes: 82024   19.15  19.08  21.76   2.69      0.02  21.85  21.84
GPU average time: 2.69
total time: 21.87
Passed

$ ":" "RUN: at line 6"
note: command had no output on stdout or stderr
$ "env" "ONEAPI_DEVICE_SELECTOR=opencl:gpu" "/__w/llvm/llvm/build-e2e/Regression/commandlist/Output/gpu.cpp.tmp.out"
# command output:
NThreads: GPU 8
   shared Queue: true
   array size: 1048576 (1<<20)
   SyCL items: 1048576
   iter GPU:   200
selected dev: Intel(R) UHD Graphics


error: command failed with exit status: -11

@jandres742
Copy link
Contributor

@intel/llvm-gatekeepers : do you want to redeploy to see if the failures are indeed flaky or can this be merged now?

@aelovikov-intel aelovikov-intel merged commit 9fcb2ac into intel:sycl Jun 26, 2023
Chenyang-L pushed a commit that referenced this pull request Jul 11, 2023
Includes a large number of missing `pi_result` mappings, so previously
reported errors should no longer map to just `PI_ERROR_UNKNOWN`. NFCI
for the adapters.
veselypeta pushed a commit to veselypeta/llvm that referenced this pull request Sep 21, 2023
Includes a large number of missing `pi_result` mappings, so previously
reported errors should no longer map to just `PI_ERROR_UNKNOWN`. NFCI
for the adapters.
fabiomestre pushed a commit to fabiomestre/llvm that referenced this pull request Sep 26, 2023
Includes a large number of missing `pi_result` mappings, so previously
reported errors should no longer map to just `PI_ERROR_UNKNOWN`. NFCI
for the adapters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants