Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Don't skip Win testing due to failing lint if ignore-lint is present #10079

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

aelovikov-intel
Copy link
Contributor

Aligns the task with its Linux counterpart.

…sent

Aligns the task with its Linux counterpart.
@aelovikov-intel
Copy link
Contributor Author

@bader
Copy link
Contributor

bader commented Jun 26, 2023

@aelovikov-intel, do you know why post-commit checks launched for the change in the pre-commit script?

@aelovikov-intel
Copy link
Contributor Author

aelovikov-intel commented Jun 26, 2023

@aelovikov-intel, do you know why post-commit checks launched for the change in the pre-commit script?

This is intentional - PR's source branch is in the origin/sycl-devops-pr/** format and is supposed to trigger post-commit on push. See #10002 's commit message for more details. I think I need to draft some docs/bkms regarding CI pre-commit testing too.

Edit: I just understood the question now. Yes, I think this can be improved slightly although it's not clear how to identify "changed" files on the push event.

@aelovikov-intel aelovikov-intel merged commit 92dbe1f into sycl Jun 26, 2023
@aelovikov-intel aelovikov-intel deleted the sycl-devops-pr/win-skip-lint branch June 26, 2023 21:05
Chenyang-L pushed a commit that referenced this pull request Jul 11, 2023
…sent (#10079)

Aligns the task with its Linux counterpart.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants