Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][ESIMD][E2E] Remove old raw_send APIs from the tests #10088

Merged
merged 1 commit into from
Jun 27, 2023
Merged

[SYCL][ESIMD][E2E] Remove old raw_send APIs from the tests #10088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions sycl/test-e2e/ESIMD/histogram_raw_send.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@
// UNSUPPORTED: ze_debug
// RUN: %{build} -o %t1.out
// RUN: %{run} %t1.out
// RUN: %{build} -DNEW_API -o %t2.out
// RUN: %{run} %t2.out

// The test checks raw send functionality with atomic write implementation
// on SKL. It does not work on DG1 due to send instruction incompatibility.
Expand Down Expand Up @@ -87,15 +85,9 @@ ESIMD_INLINE void atomic_write(T *bins, simd<unsigned, n> offset,
constexpr uint8_t numSrc1 = 0x1;
constexpr uint8_t isEOT = 0;
constexpr uint8_t isSendc = 0;
#ifdef NEW_API
experimental::esimd::raw_sends(oldDst, vAddr, src0, exDesc, desc, execSize,
sfid, numSrc0, numSrc1, numDst, isEOT, isSendc,
pred);
#else
experimental::esimd::raw_sends_load(oldDst, vAddr, src0, exDesc, desc,
execSize, sfid, numSrc0, numSrc1, numDst,
isEOT, isSendc, pred);
#endif
}

int main(int argc, char *argv[]) {
Expand Down
17 changes: 0 additions & 17 deletions sycl/test-e2e/ESIMD/vadd_raw_send.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@
// XFAIL: esimd_emulator
// RUN: %{build} -fno-sycl-esimd-force-stateless-mem -o %t1.out
// RUN: %{run} %t1.out
// RUN: %{build} -DNEW_API -fno-sycl-esimd-force-stateless-mem -o %t2.out
// RUN: %{run} %t2.out

// The test checks raw send functionality with block read/write implementation
// on SKL. It does not work on DG1 due to send instruction incompatibility.
Expand Down Expand Up @@ -42,13 +40,8 @@ ESIMD_INLINE simd<T, N> dwaligned_block_read(AccessorTy acc,
constexpr uint8_t sfid = 0x0;
constexpr uint8_t numSrc0 = 0x1;
constexpr uint8_t numDst = 0x2;
#ifdef NEW_API
return experimental::esimd::raw_send(oldDst, src0, exDesc, desc, execSize,
sfid, numSrc0, numDst);
#else
return experimental::esimd::raw_send_load(oldDst, src0, exDesc, desc,
execSize, sfid, numSrc0, numDst);
#endif
}

template <typename T, int N, typename AccessorTy>
Expand All @@ -64,13 +57,8 @@ ESIMD_INLINE void block_write1(AccessorTy acc, unsigned int offset,
constexpr uint8_t sfid = 0x0;
constexpr uint8_t numSrc0 = 0x1;
constexpr uint8_t numSrc1 = 0x1;
#ifdef NEW_API
return experimental::esimd::raw_sends(src0, data, exDesc, desc, execSize,
sfid, numSrc0, numSrc1);
#else
return experimental::esimd::raw_sends_store(src0, data, exDesc, desc,
execSize, sfid, numSrc0, numSrc1);
#endif
}

template <typename T, int N, typename AccessorTy>
Expand All @@ -89,13 +77,8 @@ ESIMD_INLINE void block_write2(AccessorTy acc, unsigned int offset,
constexpr uint8_t execSize = 0x83;
constexpr uint8_t sfid = 0x0;
constexpr uint8_t numSrc0 = 0x2;
#ifdef NEW_API
return experimental::esimd::raw_send(src0, exDesc, desc, execSize, sfid,
numSrc0);
#else
return experimental::esimd::raw_send_store(src0, exDesc, desc, execSize, sfid,
numSrc0);
#endif
}

template <typename T> int test(queue q) {
Expand Down