[SYCL] Return the correct sycl::errc in case of invalid sycl::reqd_work_group_size #10093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk_group_size According to SYCL 2020, > If a kernel is decorated with this attribute and then submitted to a device that does not support the work group size, the implementation must throw a synchronous exception with the `errc::kernel_not_supported` error code. This patch fixes sycl::errc in such case: it returned `errc::nd_range`, now it returns `errc::kernel_not_supported`.
bso-intel
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to SYCL 2020,
This patch fixes sycl::errc in such case: it returned
errc::nd_range, now it returnserrc::kernel_not_supported.