Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][WIN] Don't skip E2E tests if only check-* steps in build fail #10101

Merged
merged 1 commit into from
Jun 28, 2023
Merged

[CI][WIN] Don't skip E2E tests if only check-* steps in build fail #10101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/sycl_windows_build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ jobs:
name: Build + LIT
runs-on: [Windows, build]
# TODO use cached checkout
outputs:
build_conclusion: ${{ steps.build.conclusion }}
steps:
- uses: ilammy/msvc-dev-cmd@7315a94840631165970262a99c72cfb48a65d25d
with:
Expand Down Expand Up @@ -92,6 +94,7 @@ jobs:
run: |
cmake --build build --target check-libdevice
- name: Install
if: ${{ always() && !cancelled() && steps.build.conclusion == 'success' }}
shell: bash
# TODO replace utility installation with a single CMake target
run: |
Expand All @@ -106,18 +109,21 @@ jobs:
cmake --build build --target install-llvm-profdata
cmake --build build --target install-compiler-rt
- name: Pack toolchain
if: ${{ always() && !cancelled() && steps.build.conclusion == 'success' }}
shell: bash
run: |
tar -czf llvm_sycl.tar.gz -C install .
- name: Upload toolchain
if: ${{ always() && !cancelled() && steps.build.conclusion == 'success' }}
uses: actions/upload-artifact@v3
with:
name: sycl_windows_default
path: llvm_sycl.tar.gz

e2e-tests:
needs: build
if: ${{ inputs.lts_matrix != '[]' }}
# Continue if build was successful.
if: ${{ always() && needs.build.outputs.build_conclusion == 'success' && inputs.lts_matrix != '[]' }}
strategy:
fail-fast: false
matrix:
Expand Down