Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Remove XFAIL from SPMD_invoke_ESIMD_external.cpp #10106

Merged
merged 1 commit into from
Jun 28, 2023
Merged

[SYCL] Remove XFAIL from SPMD_invoke_ESIMD_external.cpp #10106

merged 1 commit into from
Jun 28, 2023

Conversation

jzc
Copy link
Contributor

@jzc jzc commented Jun 27, 2023 •
edited
Loading

These tests now pass after this commit: 8417687

Unexpectedly Passed Tests (2):
SYCL :: InvokeSimd/Feature/ImplicitSubgroup/SPMD_invoke_ESIMD_external.cpp
SYCL :: InvokeSimd/Feature/SPMD_invoke_ESIMD_external.cpp

@jzc jzc requested a review from a team as a code owner June 27, 2023 19:53
@jzc jzc temporarily deployed to aws June 27, 2023 19:53 — with GitHub Actions Inactive
sarnex
sarnex reviewed Jun 27, 2023
View reviewed changes
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this passing now? If so can you send me the log of it passing? Thx

@jzc
Copy link
Contributor Author

jzc commented Jun 27, 2023

Is this passing now? If so can you send me the log of it passing? Thx

I updated the PR description with the info

sarnex
sarnex approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@sarnex sarnex left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, i dont immediately know why this change fixed it but either way we should unblock the failing CI

@jzc jzc temporarily deployed to aws June 27, 2023 20:26 — with GitHub Actions Inactive
@dm-vodopyanov
Copy link
Contributor

Test failures in

  • SYCL Pre Commit / Linux SYCL E2E on Nightly / E2E on Nightly (Intel, ["Linux", "gen9"], ghcr.io/intel/llvm/sycl_ubuntu2204_nightly:latest, -u 1... / Intel (pull_request_target) Failing after 42m
  • SYCL Pre Commit / Linux SYCL E2E on Nightly / [AWS][CUDA] E2E on Nightly / CUDA (pull_request_target) Failing after 29m

are not related to this PR.

Tag @aelovikov-intel for awareness

@dm-vodopyanov dm-vodopyanov merged commit 14a9812 into intel:sycl Jun 28, 2023
@Chenyang-L Chenyang-L mentioned this pull request Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarnex sarnex sarnex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jzc @dm-vodopyanov @sarnex