[SYCL] Refactor and generate SYCL builtins #10198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the current implementation of builtins, splitting them into marray implementations and a new generator script generating the scalar and vector variants. This also makes the scalar overloads into overloads and makes the vector builtins templated on the size of the vector. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
force-pushed
the
steffen/gen_builtins
branch
from
a479a2c
to
1105d05
Compare
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
force-pushed
the
steffen/gen_builtins
branch
from
b33066b
to
a956464
Compare
|
This should be ready for review. Corresponding spec changes are in KhronosGroup/SYCL-Docs#440. |
|
@intel/sycl-language-enabling-triage: FYI |
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
dm-vodopyanov
approved these changes
Aug 8, 2023
|
Discussed with @AlexeySachkov and we agreed that all his comments had been addressed. Merging. |
whitneywhtsang
added a commit
to sys-ce-bb/llvm
that referenced
this pull request
Aug 14, 2023
This reverts commit e4676b6.
whitneywhtsang
added a commit
to whitneywhtsang/llvm
that referenced
this pull request
Aug 14, 2023
…)"" This reverts commit 3393304.
| // RUN: %{run} %t.out | ||
|
|
||
| #ifdef _WIN32 | ||
| #define _USE_MATH_DEFINES // To use vath constants |
There was a problem hiding this comment.
Typo? "vath" -> "math"
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
This commit changes the builtin headers from defining all SYCL builtins to using a number of generated header files containing these builtin functions. --------- Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the builtin headers from defining all SYCL builtins to using a number of generated header files containing these builtin functions.