Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test-e2e][Matrix] Fix joint matrix load address #10259

Merged
merged 2 commits into from
Jul 11, 2023
Merged

[test-e2e][Matrix] Fix joint matrix load address #10259

merged 2 commits into from
Jul 11, 2023

Conversation

Nuullll
Copy link
Contributor

@Nuullll Nuullll commented Jul 7, 2023 •
edited
Loading

The loading address didn't calculate the column offset right w.r.t the sub-group id.

Signed-off-by: Yilong Guo yilong.guo@intel.com

@Nuullll
[test-e2e][Matrix] Fix joint matrix load address
95cfd36 
The loading address offset didn't calculate the column offset right
w.r.t the sub-group id.

Signed-off-by: Yilong Guo <yilong.guo@intel.com>
@Nuullll Nuullll temporarily deployed to aws July 7, 2023 02:32 — with GitHub Actions Inactive
@Nuullll Nuullll temporarily deployed to aws July 7, 2023 03:08 — with GitHub Actions Inactive
@YuriPlyakhin
Copy link
Contributor

@arnamoy10 , could you please take a look, as the author of the original test? Thanks!

@YuriPlyakhin YuriPlyakhin mentioned this pull request Jul 7, 2023
Merged
@Nuullll Nuullll temporarily deployed to aws July 10, 2023 01:47 — with GitHub Actions Inactive
@arnamoy10
Copy link
Contributor

LGTM

@Nuullll Nuullll temporarily deployed to aws July 10, 2023 02:21 — with GitHub Actions Inactive
@Nuullll Nuullll requested a review from bader July 11, 2023 02:07
@Nuullll
Copy link
Contributor Author

Nuullll commented Jul 11, 2023 •
edited
Loading

@bader Could you please help merge this? The failures on HIP/CUDA backend are irrelevant.

@bader
Copy link
Contributor

bader commented Jul 11, 2023

@bader Could you please help merge this? The failures on HIP/CUDA backend are irrelevant.

@Nuullll, please, ping @intel/llvm-gatekeepers for help with merging the PR.

@Nuullll
Copy link
Contributor Author

Nuullll commented Jul 11, 2023

@bader Could you please help merge this? The failures on HIP/CUDA backend are irrelevant.

@Nuullll, please, ping @intel/llvm-gatekeepers for help with merging the PR.

Sorry for the spam.

@intel/llvm-gatekeepers Can you please help merge this?

@Nuullll Nuullll requested review from a team and removed request for bader July 11, 2023 02:58
@aelovikov-intel
Copy link
Contributor

PR only modifies E2E tests and those modified pass. Failures on others might be caused by slight out-of-sync between nightly and PR's head.

@aelovikov-intel aelovikov-intel merged commit 276b9cf into intel:sycl Jul 11, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriPlyakhin YuriPlyakhin YuriPlyakhin approved these changes

@dkhaldi dkhaldi Awaiting requested review from dkhaldi

@yubingex007-a11y yubingex007-a11y Awaiting requested review from yubingex007-a11y

@arnamoy10 arnamoy10 Awaiting requested review from arnamoy10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Nuullll @YuriPlyakhin @arnamoy10 @bader @aelovikov-intel