Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Joint Matrix] Fix typo in matrix_combinations on PVC #11837

Merged

Conversation

dm-vodopyanov
Copy link
Contributor

According to
https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_matrix/sycl_ext_oneapi_matrix.asciidoc#intel-xmx-supported-combinations
for PVC: matrix_type::sint8, matrix_type::sint8, matrix_type::sint32, <=8, 16, 32 but implementation had a typo: K == 16 instead of 32, fixed by this patch

According to
https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_matrix/sycl_ext_oneapi_matrix.asciidoc#intel-xmx-supported-combinations
for PVC: `matrix_type::sint8`, `matrix_type::sint8`, `matrix_type::sint32`, `<=8`, `16`, `32`
but implementation had a typo: K == 16 instead of 32, fixed by this
patch
@dm-vodopyanov dm-vodopyanov requested a review from a team as a code owner November 9, 2023 15:02
@dm-vodopyanov dm-vodopyanov changed the title [SYCL][Joint Matrix] Fix typo in matrix_combinations [SYCL][Joint Matrix] Fix typo in matrix_combinations on PVC Nov 9, 2023
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dm-vodopyanov
Copy link
Contributor Author

Failure in SYCL :: Graph/RecordReplay/multiple_exec_graphs.cpp is unrelated, submitted #11852

@dm-vodopyanov dm-vodopyanov merged commit 484db83 into intel:sycl Nov 10, 2023
11 of 12 checks passed
dm-vodopyanov added a commit to dm-vodopyanov/llvm that referenced this pull request Nov 13, 2023
aelovikov-intel pushed a commit that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants