Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UR] Bump tag to 47af3ee2 #11868

Merged
merged 1 commit into from
Dec 1, 2023
Merged

[UR] Bump tag to 47af3ee2 #11868

merged 1 commit into from
Dec 1, 2023

Conversation

omarahmed1111
Copy link
Contributor

@omarahmed1111 omarahmed1111 commented Nov 13, 2023 •
edited
Loading

testing branch for PR and adding necessary fixes for it.

@omarahmed1111 omarahmed1111 mentioned this pull request Nov 14, 2023
Merged
@omarahmed1111 omarahmed1111 force-pushed the testing-pr-for-adapter-bump-third-patch branch from 2c60c70 to 7a008a6 Compare November 15, 2023 12:22
@omarahmed1111 omarahmed1111 force-pushed the testing-pr-for-adapter-bump-third-patch branch 2 times, most recently from e1ca739 to 1371288 Compare November 21, 2023 11:37
@aelovikov-intel
Copy link
Contributor

Lots of tests are failing by timeout. I'm killing the task and won't be approving Win CI tasks for UR patches in the nearest future.

@omarahmed1111
Copy link
Contributor Author

omarahmed1111 commented Nov 29, 2023 •
edited
Loading

Lots of tests are failing by timeout. I'm killing the task and won't be approving Win CI tasks for UR patches in the nearest future.

Apologies, We just had some Windows failure with this PR and should have been fixed in here which will be included in next push in this PR.

@omarahmed1111 omarahmed1111 force-pushed the testing-pr-for-adapter-bump-third-patch branch from 1371288 to 692a431 Compare November 29, 2023 15:00
@omarahmed1111 omarahmed1111 force-pushed the testing-pr-for-adapter-bump-third-patch branch from 692a431 to 95ebcb1 Compare November 30, 2023 11:35
@omarahmed1111 omarahmed1111 force-pushed the testing-pr-for-adapter-bump-third-patch branch 2 times, most recently from cc36afd to 6971a9f Compare November 30, 2023 11:54
@omarahmed1111 omarahmed1111 force-pushed the testing-pr-for-adapter-bump-third-patch branch from 6971a9f to d69fc99 Compare November 30, 2023 12:51
@omarahmed1111 omarahmed1111 marked this pull request as ready for review November 30, 2023 15:01
@omarahmed1111 omarahmed1111 requested review from a team as code owners November 30, 2023 15:01
@omarahmed1111 omarahmed1111 changed the title Testing for UR adapter branch bump third patch Testing for UR adapter branch bump to main Nov 30, 2023
kbenzie
kbenzie reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge in the latest sycl branch and update the UR tag.

sycl/plugins/unified_runtime/CMakeLists.txt Outdated Show resolved Hide resolved
@omarahmed1111 omarahmed1111 force-pushed the testing-pr-for-adapter-bump-third-patch branch from d69fc99 to d4f1cb3 Compare November 30, 2023 16:28
@kbenzie kbenzie changed the title Testing for UR adapter branch bump to main [UR] Bump tag to 47af3ee2 Nov 30, 2023
@EwanC
Copy link
Contributor

EwanC commented Dec 1, 2023

@intel/llvm-gatekeepers Can we merge this please

@steffenlarsen steffenlarsen merged commit 2f644e3 into intel:sycl Dec 1, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbenzie kbenzie kbenzie approved these changes

@EwanC EwanC EwanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@omarahmed1111 @aelovikov-intel @EwanC @kbenzie @steffenlarsen