[SYCL] Evict program cache on PI_ERROR_OUT_OF_RESOURCES #11987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzc
force-pushed
the
program-cache-eviction
branch
from
cb29584
to
9dce9fb
Compare
jzc
commented
Dec 5, 2023
| // CHECK-CACHE: piKernelRelease | ||
| // CHECK-CACHE: piKernelRelease | ||
| // CHECK-CACHE: piProgramRelease | ||
| // CHECK-CACHE: piProgramRelease |
There was a problem hiding this comment.
The cache is destructed in a different order now, which is why these are swapped. Also the previous version of this test only had 2 checks for release of program/kernel even though there were 3 programs/kernels that should have been created, which is why any extra check was added.
steffenlarsen
approved these changes
Dec 7, 2023
KornevNikita
added a commit
to KornevNikita/llvm
that referenced
this pull request
Jun 10, 2024
I'm observing cache overflow when running heavy tests on OCL backend with gpu. Clear cache in case of PI_ERROR_OUT_OF_HOST_MEMORY as well as for PI_ERROR_OUT_OF_RESOURCES. Using as reference: intel#11987
dm-vodopyanov
pushed a commit
that referenced
this pull request
Jun 13, 2024
I'm observing cache overflow when running heavy tests on OCL backend with gpu. Clear cache in case of PI_ERROR_OUT_OF_HOST_MEMORY as well as for PI_ERROR_OUT_OF_RESOURCES. Using as reference: #11987
ianayl
pushed a commit
to ianayl/sycl
that referenced
this pull request
Jun 13, 2024
I'm observing cache overflow when running heavy tests on OCL backend with gpu. Clear cache in case of PI_ERROR_OUT_OF_HOST_MEMORY as well as for PI_ERROR_OUT_OF_RESOURCES. Using as reference: intel#11987
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds resource cleanup mechanisms when
PI_ERROR_OUT_OF_RESOURCESoccurs onpiProgramBuildandpiProgramLink. Currently. the whole cache is cleared, but this behavior can be extended in the future. In order to ensure thread safety of the cache clearing mechanism, the maps of the cache now hold theirBuildResult's inshared_ptr's, which allows the cache to be cleared even if there are still threads that still hold references to aBuildResult.