Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[L0] Add support for multi-device kernel compilation #12032

Merged
merged 3 commits into from
Jan 23, 2024
Merged

[L0] Add support for multi-device kernel compilation #12032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36a889f
[L0] Add support for multi-device kernel compilation
nrspruit Nov 29, 2023
51d487a
Merge remote-tracking branch 'origin/sycl' into pre_commit_multi_devi…
kbenzie Jan 23, 2024
2aff3fb
[UR] Bump tag to 7c58060f
kbenzie Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sycl/plugins/unified_runtime/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,13 @@ if(SYCL_PI_UR_USE_FETCH_CONTENT)
include(FetchContent)

set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
# commit 6032f6fde37eeadcc3f12c10460e3ffec161dd33
# Merge: 92f44da3 f9ad3d42
# commit 7c58060ffdd86e1e342e9bea12834e49aa2cb187
# Merge: 4f800802 1b2cd5b3
# Author: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
# Date: Mon Jan 22 12:30:12 2024 +0000
# Merge pull request #1259 from igchor/fix_sync
# [L0] do not ignore returned values from zeHostSynchronize
set(UNIFIED_RUNTIME_TAG 6032f6fde37eeadcc3f12c10460e3ffec161dd33)
# Date: Tue Jan 23 11:29:19 2024 +0000
# Merge pull request #1135 from nrspruit/multi_device_kernel_compilation_main
# [L0] Add support for multi-device kernel compilation
set(UNIFIED_RUNTIME_TAG 7c58060ffdd86e1e342e9bea12834e49aa2cb187)

if(SYCL_PI_UR_OVERRIDE_FETCH_CONTENT_REPO)
set(UNIFIED_RUNTIME_REPO "${SYCL_PI_UR_OVERRIDE_FETCH_CONTENT_REPO}")
Expand Down
18 changes: 0 additions & 18 deletions sycl/plugins/unified_runtime/pi2ur.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1875,11 +1875,6 @@ inline pi_result piProgramCreateWithBinary(
PI_ASSERT(Binaries && Lengths, PI_ERROR_INVALID_VALUE);
PI_ASSERT(Program, PI_ERROR_INVALID_PROGRAM);

// For now we support only one device.
if (NumDevices != 1) {
die("piProgramCreateWithBinary: level_zero supports only one device.");
return PI_ERROR_INVALID_VALUE;
}
if (!Binaries[0] || !Lengths[0]) {
if (BinaryStatus)
*BinaryStatus = PI_ERROR_INVALID_VALUE;
Expand Down Expand Up @@ -1981,11 +1976,6 @@ piProgramLink(pi_context Context, pi_uint32 NumDevices,
pi_uint32 NumInputPrograms, const pi_program *InputPrograms,
void (*PFnNotify)(pi_program Program, void *UserData),
void *UserData, pi_program *RetProgram) {
// We only support one device with Level Zero currently.
if (NumDevices != 1) {
die("piProgramLink: level_zero supports only one device.");
return PI_ERROR_INVALID_VALUE;
}

// Validate input parameters.
PI_ASSERT(DeviceList, PI_ERROR_INVALID_DEVICE);
Expand Down Expand Up @@ -2060,14 +2050,6 @@ piProgramBuild(pi_program Program, pi_uint32 NumDevices,
return PI_ERROR_INVALID_VALUE;
}

// We only support build to one device with Level Zero now.
// TODO: we should eventually build to the possibly multiple root
// devices in the context.
if (NumDevices != 1) {
die("piProgramBuild: level_zero supports only one device.");
return PI_ERROR_INVALID_VALUE;
}

// These aren't supported.
PI_ASSERT(!PFnNotify && !UserData, PI_ERROR_INVALID_VALUE);

Expand Down