Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][NFC] Move LowerWGScope pass to LLVM project #1306

Merged
merged 2 commits into from
Mar 13, 2020

Conversation

againull
Copy link
Contributor

LowerWGScope pass is an llvm pass that performs SYCL specific
transformations in LLVM IR right after frontend. LLVM passes are
supposed to be in llvm project and not in clang project.

Also added LIT tests.

Signed-off-by: Artur Gainullin artur.gainullin@intel.com

againull added 2 commits March 9, 2020 18:41
LowerWGScope pass is an llvm pass that performs SYCL specific
transformations in LLVM IR right after frontend. LLVM passes are
supposed to be in llvm project and not in clang project.

Signed-off-by: Artur Gainullin <artur.gainullin@intel.com>
Signed-off-by: Artur Gainullin <artur.gainullin@intel.com>
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No functional changes. Right?

@bader bader changed the title [SYCL] Move LowerWGScope pass to LLVM project [SYCL][NFC] Move LowerWGScope pass to LLVM project Mar 13, 2020
@bader bader merged commit 35ee8d2 into intel:sycl Mar 13, 2020
@againull againull deleted the move_to_llvm_project branch December 3, 2022 00:02
aelovikov-intel added a commit to aelovikov-intel/llvm that referenced this pull request Feb 23, 2023
On windows, -lsycl have to be changed to -lsycl6 for the gcc-style
invocations. Note that clang-cl style had been updated sycl.lib ->
sycl6.lib before.

I originally tried to get rid of explicit library name by using "-fsycl"
instead but it would break some tests for explicit manual compilation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants