Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Fix headers location for check-sycl-deploy target #1343

Merged
merged 1 commit into from
Mar 19, 2020
Merged

[SYCL] Fix headers location for check-sycl-deploy target #1343

merged 1 commit into from
Mar 19, 2020

Conversation

vladimirlaz
Copy link
Contributor

Signed-off-by: Vladimir Lazarev vladimir.lazarev@intel.com

@vladimirlaz
[SYCL] Fix headers location for check-sycl-deploy target
c10d6b6 
Signed-off-by: Vladimir Lazarev <vladimir.lazarev@intel.com>
@bader
Copy link
Contributor

bader commented Mar 18, 2020

Is it going to fix #1342 and #1337?

@bader
Copy link
Contributor

bader commented Mar 18, 2020 •
edited
Loading

Is it going to fix #1342 and #1337?

I think it doesn't fix those issue.
@vladimirlaz, please, take a look at them. I think they were introduced by your recent patch with SYCL headers re-locataion.

@vladimirlaz
Copy link
Contributor Author

vladimirlaz commented Mar 18, 2020 •
edited
Loading

Is it going to fix #1342 and #1337?

I think it doesn't fix those issue.
@vladimirlaz, please, take a look at them. I think they were introduced by your recent patch with SYCL headers re-locataion.

It will not fix.
#1342 will be fixed later in CI scripts (it should be fixed by tomorrow). I am working on #1337 right now (clang driver change is coming).

@vladimirlaz vladimirlaz merged commit d7b059e into intel:sycl Mar 19, 2020
@vladimirlaz vladimirlaz deleted the private/vlazarev/fix_misprint branch March 19, 2020 10:12
@KseniyaTikhomirova KseniyaTikhomirova mentioned this pull request Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

Assignees

@bader bader

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladimirlaz @bader