Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][COMPAT] Add math extend_vcompare[2/4] to SYCLCompat #14079

Merged
merged 42 commits into from
Jun 14, 2024
Merged

[SYCL][COMPAT] Add math extend_vcompare[2/4] to SYCLCompat #14079

merged 42 commits into from
Jun 14, 2024

Conversation

OuadiElfarouki
Copy link
Contributor

@OuadiElfarouki OuadiElfarouki commented Jun 6, 2024 •
edited
Loading

This PR adds math extend_vcompare[2/4] operators (4 in total) along with unit-tests for signed and unsigned int32 cases.
Also, Unit-tests from previous extend_v*4 #14078 and extend_v*2 #13953 are moved to two different files.

OuadiElfarouki and others added 17 commits May 29, 2024 19:43
@OuadiElfarouki
[SYCL][COMPAT] add math extend_v*2 to SYCLCompat
2f908c4
@OuadiElfarouki
Merge branch 'sycl' into math_extend_v2
f5b7e11
@OuadiElfarouki
minor layout changes
3fa6edd
@OuadiElfarouki @Alcpz
Update sycl/test-e2e/syclcompat/math/math_extend_v.cpp
033164e 
Co-authored-by: Alberto Cabrera Pérez <alberto.cabrera@intel.com>
@OuadiElfarouki
Fixed some gaps in test cases and other typo fixes
ca1f991
@OuadiElfarouki
Explicit casting to extended uint type
a9d33b3
@OuadiElfarouki
Minor fixes & reformatting
cd86f19
@OuadiElfarouki
Extended some tests to cover mixed types
d65ab3b
@OuadiElfarouki
fix to zero_or_signed_extend
065d920
@OuadiElfarouki
Added extend_v2 APIs doc to readme
29ae741
@OuadiElfarouki @joeatodd
Apply suggestions from code review
5e577bf 
Co-authored-by: Joe Todd <joe.todd@codeplay.com>
@OuadiElfarouki
fixed formatting
7018d4f
@OuadiElfarouki
Merge branch 'sycl' into math_extend_v2
18c0163
@OuadiElfarouki
Merge branch 'sycl' into math_extend_v2
d9d295c
@OuadiElfarouki
[SYCL][COMPAT] add math extend_v*4 to SYCLCompat
cfa08ae
@OuadiElfarouki
Added missing test
1e04a11
@OuadiElfarouki
[SYCL][COMPAT] add math extend_vcompare[2/4] to SYCLCompat
b3953c1
@OuadiElfarouki OuadiElfarouki requested a review from a team as a code owner June 6, 2024 13:18
Alcpz
Alcpz requested changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@Alcpz Alcpz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor stuff in the docs, otherwise LGTM, The review assumes that extend_vbinary2 and extend_vbinary4 are gonna be reviewed in their respective PRs.

sycl/doc/syclcompat/README.md Outdated Show resolved Hide resolved
sycl/include/syclcompat/math.hpp Outdated Show resolved Hide resolved
sycl/include/syclcompat/math.hpp Outdated Show resolved Hide resolved
sycl/test-e2e/syclcompat/math/math_extend_v.cpp Outdated Show resolved Hide resolved
yihanwg
yihanwg approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@yihanwg yihanwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OuadiElfarouki
Copy link
Contributor Author

Due to the timeout of the math_extend_v tests causing the CI to fail, I just broke it down to 2 separate test files (one for each vectorization size).

@OuadiElfarouki
Copy link
Contributor Author

@intel/llvm-gatekeepers PR should be ready! Thanks.

@steffenlarsen steffenlarsen merged commit 73cf85d into intel:sycl Jun 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alcpz Alcpz Alcpz approved these changes

@yihanwg yihanwg yihanwg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@OuadiElfarouki @Alcpz @yihanwg @joeatodd @steffenlarsen