[New offload driver][Device lib] Add SYCL device library files for all targets #14102
+30
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asudarsa
commented
Jun 9, 2024
| // TODO(NOM1): Support target triples in a more generic way. | ||
| // TODO(NOM3): Investigate why passing spirv64-unknown-unknown does not | ||
| // work. | ||
| if (TargetTriple.isSPIR()) |
There was a problem hiding this comment.
We should not pass target triple to linker wrapper. This information is available inside the device images.
asudarsa
force-pushed
the
add_sycl_device_lib_files_for_all_targets
branch
from
7c48cf7
to
46cdf02
Compare
mdtoguchi
approved these changes
Jun 10, 2024
asudarsa
force-pushed
the
add_sycl_device_lib_files_for_all_targets
branch
from
46cdf02
to
e0c6fe2
Compare
|
@intel/llvm-gatekeepers Can you please merge? This is ready for merging. Thanks |
steffenlarsen
requested changes
Jun 11, 2024
There was a problem hiding this comment.
Driver/sycl-offload-new-driver.c is failing in post-commit after #14091. I am blocking this PR until the patch has either been reverted or the test failure has been addressed.
steffenlarsen
approved these changes
Jun 11, 2024
…l targets Signed-off-by: Arvind Sudarsanam <arvind.sudarsanam@intel.com>
Signed-off-by: Arvind Sudarsanam <arvind.sudarsanam@intel.com>
Signed-off-by: Arvind Sudarsanam <arvind.sudarsanam@intel.com>
Signed-off-by: Arvind Sudarsanam <arvind.sudarsanam@intel.com>
asudarsa
force-pushed
the
add_sycl_device_lib_files_for_all_targets
branch
from
e0c6fe2
to
e6b6acd
Compare
|
@intel/llvm-gatekeepers |
ianayl
pushed a commit
to ianayl/sycl
that referenced
this pull request
Jun 13, 2024
…l targets (intel#14102) clang-linker-wrapper is not target-specific. i.e. it is not called for a single target device. It is called only once. Currently, clang-linker-wrapper is called only with device images with spir64 targets. So, the existing approach to capture the first target triple in the list of triples and use it for gathering sycl-device-library files is valid. As we plan to add support for more targets (AOT), we need to gather sycl-device-libraries for all targets. This PR addresses this change. Also, the triple should not be passed to the linker wrapper. The linker wrapper should get the triples from device images. Thanks --------- Signed-off-by: Arvind Sudarsanam <arvind.sudarsanam@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-linker-wrapper is not target-specific. i.e. it is not called for a single target device. It is called only once.
Currently, clang-linker-wrapper is called only with device images with spir64 targets. So, the existing approach to capture the first target triple in the list of triples and use it for gathering sycl-device-library files is valid. As we plan to add support for more targets (AOT), we need to gather sycl-device-libraries for all targets. This PR addresses this change.
Also, the triple should not be passed to the linker wrapper. The linker wrapper should get the triples from device images.
Thanks