[Driver][SYCL][NewOffloadModel] Incorporate -device settings for GPU #14151
Conversation
One of the models that is used for specifying the device architecture for spir64_gen is to use the -Xsycl-target-backend "-device arg" syntax on the command line. Hook up the ability to scan the target backend values to embed the proper information in the packaged binary when using the new offload model.
clang/lib/Driver/Driver.cpp
Outdated
| bool DeviceSeen = false; | ||
| StringRef DeviceArg; | ||
| for (StringRef ArgString : TargetArgs) { | ||
| // Look for -device <string> and use that as the known arch to |
There was a problem hiding this comment.
Do we expect multiple entries here? If so, do we expect to honor the right most entry?
Also, can we please have a test case to cover this?
Thanks
There was a problem hiding this comment.
Typical usage is to not have multiple entries - but we need to make sure we have a behavior that covers it. I will add a test.
clang/lib/Driver/Driver.cpp
Outdated
| // Capture the argument for '-device' | ||
| bool DeviceSeen = false; | ||
| StringRef DeviceArg; | ||
| for (StringRef ArgString : TargetArgs) { |
There was a problem hiding this comment.
I can think of a few ways to optimize this.
for (int i = TargetArgs.size()-1; i >=0; --i)
if (TargetArgs[i] == "-device") {
Arch = TargetArgs[i+1];
break;
}
There was a problem hiding this comment.
Makes sense - I will update.
There was a problem hiding this comment.
for (int i = TargetArgs.size()-1; i >=0; --i)
It should be TargetArgs.size()-2 instead of TargetArgs.size()-1 to avoid potential out-of-bounds access in Arch = TargetArgs[i+1];.
|
@intel/llvm-gatekeepers, could this PR be merged? thanks! |
…ntel#14151) One of the models that is used for specifying the device architecture for spir64_gen is to use the -Xsycl-target-backend "-device arg" syntax on the command line. Hook up the ability to scan the target backend values to embed the proper information in the packaged binary when using the new offload model.
One of the models that is used for specifying the device architecture for spir64_gen is to use the -Xsycl-target-backend "-device arg" syntax on the command line.
Hook up the ability to scan the target backend values to embed the proper information in the packaged binary when using the new offload model.