Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][E2E] Bypass L0 adapter tracing in grf tests #15167

Merged
merged 2 commits into from
Aug 26, 2024
Merged

[SYCL][E2E] Bypass L0 adapter tracing in grf tests #15167

merged 2 commits into from
Aug 26, 2024

Conversation

callumfare
Copy link
Contributor

The L0 adapter tracing interferes with regular tracing, so don't use the normal env var to enable tracing in these tests.

@callumfare callumfare requested review from a team as code owners August 22, 2024 12:14
@callumfare
Copy link
Contributor Author

CI failures are unrelated to the change

@callumfare callumfare mentioned this pull request Aug 22, 2024
Closed
@callumfare
[SYCL][E2E] Bypass L0 adapter tracing in grf tests
c175d1a 
The L0 adapter tracing interferes with regular tracing, so don't use the normal
env var to enable tracing in these tests.
sarnex
sarnex approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming tests pass now :)

@sarnex
Copy link
Contributor

sarnex commented Aug 26, 2024

CI fail not related

@sarnex sarnex merged commit 3e00e38 into intel:sycl Aug 26, 2024
11 of 12 checks passed
lslusarczyk added a commit to lslusarczyk/llvm that referenced this pull request Sep 20, 2024
@lslusarczyk
[SYCL][E2E] Reverted bypass of L0 adapter tracing in grf tests
653c968 
Revert "[SYCL][E2E] Bypass L0 adapter tracing in grf tests (intel#15167)"
because oneapi-src/unified-runtime#2002 is
fixed

This reverts commit 3e00e38.
lslusarczyk added a commit to lslusarczyk/llvm that referenced this pull request Sep 20, 2024
@lslusarczyk
[SYCL][E2E] Reverted bypass of L0 adapter tracing in grf tests
d3d5ed2 
Revert "[SYCL][E2E] Bypass L0 adapter tracing in grf tests (intel#15167)"
because oneapi-src/unified-runtime#2002 is
fixed

This reverts commit 3e00e38.
@lslusarczyk lslusarczyk mentioned this pull request Sep 20, 2024
Merged
lslusarczyk added a commit to lslusarczyk/llvm that referenced this pull request Sep 20, 2024
@lslusarczyk
[SYCL][E2E] Reverted bypass of L0 adapter tracing in grf tests
a9863d6 
Revert "[SYCL][E2E] Bypass L0 adapter tracing in grf tests (intel#15167)"
because oneapi-src/unified-runtime#2002 is
fixed

This reverts commit 3e00e38.
lslusarczyk added a commit to lslusarczyk/llvm that referenced this pull request Sep 20, 2024
@lslusarczyk
[SYCL][E2E] Reverted bypass of L0 adapter tracing in grf tests
ad6ee70 
Revert "[SYCL][E2E] Bypass L0 adapter tracing in grf tests (intel#15167)"
because oneapi-src/unified-runtime#2002 is
fixed

This reverts commit 3e00e38.
lslusarczyk added a commit to lslusarczyk/llvm that referenced this pull request Sep 21, 2024
@lslusarczyk
[SYCL][E2E] Reverted bypass of L0 adapter tracing in grf tests
4ff661f 
Revert "[SYCL][E2E] Bypass L0 adapter tracing in grf tests (intel#15167)"
because oneapi-src/unified-runtime#2002 is
fixed

This reverts commit 3e00e38.
lslusarczyk added a commit to lslusarczyk/llvm that referenced this pull request Sep 23, 2024
@lslusarczyk
[SYCL][E2E] Reverted bypass of L0 adapter tracing in grf tests
b1e320d 
Revert "[SYCL][E2E] Bypass L0 adapter tracing in grf tests (intel#15167)"
because oneapi-src/unified-runtime#2002 is
fixed

This reverts commit 3e00e38.
lslusarczyk added a commit to lslusarczyk/llvm that referenced this pull request Sep 23, 2024
@lslusarczyk
[SYCL][E2E] Reverted bypass of L0 adapter tracing in grf tests
685e53a 
Revert "[SYCL][E2E] Bypass L0 adapter tracing in grf tests (intel#15167)"
because oneapi-src/unified-runtime#2002 is
fixed

This reverts commit 3e00e38.
lslusarczyk added a commit to lslusarczyk/llvm that referenced this pull request Sep 23, 2024
@lslusarczyk
[SYCL][E2E] Reverted bypass of L0 adapter tracing in grf tests
ec55d82 
Revert "[SYCL][E2E] Bypass L0 adapter tracing in grf tests (intel#15167)"
because oneapi-src/unified-runtime#2002 is
fixed

This reverts commit 3e00e38.
lslusarczyk added a commit to lslusarczyk/llvm that referenced this pull request Sep 25, 2024
@lslusarczyk
[SYCL][E2E] Reverted bypass of L0 adapter tracing in grf tests
5a11a18 
Revert "[SYCL][E2E] Bypass L0 adapter tracing in grf tests (intel#15167)"
because oneapi-src/unified-runtime#2002 is
fixed

This reverts commit 3e00e38.
lslusarczyk added a commit to lslusarczyk/llvm that referenced this pull request Sep 25, 2024
@lslusarczyk
[SYCL][E2E] Reverted bypass of L0 adapter tracing in grf tests
1fcce84 
Revert "[SYCL][E2E] Bypass L0 adapter tracing in grf tests (intel#15167)"
because oneapi-src/unified-runtime#2002 is
fixed

This reverts commit 3e00e38.
lslusarczyk added a commit to lslusarczyk/llvm that referenced this pull request Sep 26, 2024
@lslusarczyk
[SYCL][E2E] Reverted bypass of L0 adapter tracing in grf tests (intel…
969fd1f 
…#15439)

Revert "[SYCL][E2E] Bypass L0 adapter tracing in grf tests (intel#15167)"
because oneapi-src/unified-runtime#2002 is
fixed

This reverts commit 3e00e38.
lslusarczyk added a commit to lslusarczyk/llvm that referenced this pull request Sep 26, 2024
@lslusarczyk
[SYCL][E2E] Reverted bypass of L0 adapter tracing in grf tests (intel…
d60f4b4 
…#15439)

Revert "[SYCL][E2E] Bypass L0 adapter tracing in grf tests (intel#15167)"
because oneapi-src/unified-runtime#2002 is
fixed

This reverts commit 3e00e38.
lslusarczyk added a commit to lslusarczyk/llvm that referenced this pull request Sep 26, 2024
@lslusarczyk
[SYCL][E2E] Reverted bypass of L0 adapter tracing in grf tests (intel…
89d69e7 
…#15439)

Revert "[SYCL][E2E] Bypass L0 adapter tracing in grf tests (intel#15167)"
because oneapi-src/unified-runtime#2002 is
fixed

This reverts commit 3e00e38.
lslusarczyk added a commit to lslusarczyk/llvm that referenced this pull request Sep 27, 2024
@lslusarczyk
[SYCL][E2E] Reverted bypass of L0 adapter tracing in grf tests (intel…
a46743e 
…#15439)

Revert "[SYCL][E2E] Bypass L0 adapter tracing in grf tests (intel#15167)"
because oneapi-src/unified-runtime#2002 is
fixed

This reverts commit 3e00e38.
lslusarczyk added a commit to lslusarczyk/llvm that referenced this pull request Oct 2, 2024
@lslusarczyk
[SYCL][E2E] Reverted bypass of L0 adapter tracing in grf tests (intel…
0180aa7 
…#15439)

Revert "[SYCL][E2E] Bypass L0 adapter tracing in grf tests (intel#15167)"
because oneapi-src/unified-runtime#2002 is
fixed

This reverts commit 3e00e38.
lslusarczyk added a commit to lslusarczyk/llvm that referenced this pull request Oct 3, 2024
@lslusarczyk
[SYCL][E2E] Reverted bypass of L0 adapter tracing in grf tests (intel…
a7290a9 
…#15439)

Revert "[SYCL][E2E] Bypass L0 adapter tracing in grf tests (intel#15167)"
because oneapi-src/unified-runtime#2002 is
fixed

This reverts commit 3e00e38.
steffenlarsen pushed a commit that referenced this pull request Oct 3, 2024
@lslusarczyk @pbalcer
[SYCL][E2E] fixed UR FileCheck conditions to match new traces (#15439)
e3cfbfe 
Issue with ugly interleaved Level0 adapter and Level0 Unified Runtime
traces, that is
oneapi-src/unified-runtime#2002 issue, has
been fixed in oneapi-src/unified-runtime#2101.

This PR adds necessary changes to e2e tests to make them pass with
modified tracing in L0 Adapter.
This PR also reverts #15167 which
disabled some traces because of the bug which is now fixed, so traces
can be restored.

---------

Co-authored-by: Piotr Balcer <piotr.balcer@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarnex sarnex sarnex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@callumfare @sarnex