-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Bindless] Allow 3-channel image formats #15210
Open
ProGTX
wants to merge
7
commits into
intel:sycl
Choose a base branch
from
codeplaysoftware:peter/3channel
base: sycl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Aug 28, 2024
-
[SYCL][Bindless] Allow 3-channel image formats
This patch doesn't implement support for 3-channel formats, it just allows it in the spec and implementation so that a backend could implement it later (e.g. Level Zero). * Removed check from `image_descriptor::verify` * Updated spec to allow 3-channel formats * Very simple test, just verifies that CUDA backend still fails * Missing some PTX intrinsics, use `float4` instead of `float4` when compiling for CUDA. The more important part is checking that the CUDA backend throws an exception when trying to create image.
Configuration menu - View commit details
-
Copy full SHA for 5309b94 - Browse repository at this point
Copy the full SHA 5309b94View commit details
Commits on Aug 29, 2024
-
Update sycl/test-e2e/bindless_images/3_channel_format.cpp
Co-authored-by: Wenju He <wenju.he@intel.com>
Configuration menu - View commit details
-
Copy full SHA for e0f186e - Browse repository at this point
Copy the full SHA e0f186eView commit details -
Currently no way to query whether a backends supports 3 channel formats.
Configuration menu - View commit details
-
Copy full SHA for f30fbaa - Browse repository at this point
Copy the full SHA f30fbaaView commit details -
Merge branch 'sycl' into peter/3channel
# Conflicts: # sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc
Configuration menu - View commit details
-
Copy full SHA for 718e917 - Browse repository at this point
Copy the full SHA 718e917View commit details
Commits on Sep 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a774038 - Browse repository at this point
Copy the full SHA a774038View commit details -
Configuration menu - View commit details
-
Copy full SHA for 42faaef - Browse repository at this point
Copy the full SHA 42faaefView commit details
Commits on Sep 13, 2024
-
Merge branch 'sycl' into peter/3channel
# Conflicts: # sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc
Configuration menu - View commit details
-
Copy full SHA for b373861 - Browse repository at this point
Copy the full SHA b373861View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.