[SYCL] Report deferred diagnostics in function templates #5114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have marked this "draft" because I am not really sure if there is a better way to handle this. Please take a look and offer suggestions for a different approach if you think of any. |
Fznamznon
reviewed
Dec 9, 2021
Fznamznon
reviewed
Dec 10, 2021
premanandrao
force-pushed
the
remote_templ_diag
branch
from
d62a761 to
64b7a0f
Compare
|
Sorry for the forced update. Branches were out of sync. |
|
I am looking at the failing test. |
Under some circumstances, deferred diagnostics were not emitted for usages within a template function. This was because the FunctionDecl associated with the diagnostic was that of the template declaration, but at the point of emitting the diagnostic, the FunctionDecl in the call chain was that of the template instantiation. Signed-off-by: Premanand M Rao <premanand.m.rao@intel.com>
premanandrao
force-pushed
the
remote_templ_diag
branch
from
64b7a0f to
4965d65
Compare
|
I had to rebase. There were some interactions between PR #5195 and this one. I have resolved one test which had a FIXME in it. |
|
@Fznamznon, @elizabethandrews, @smanna12, this is ready for a review, whenever you get a chance. |
Fznamznon
reviewed
Jan 19, 2022
Duh! Thanks. :-) |
Fznamznon
reviewed
Jan 20, 2022
Fznamznon
approved these changes
Jan 20, 2022
smanna12
approved these changes
Jan 20, 2022
Thanks @smanna12 |
|
Thanks @Fznamznon for the approval as well as the thorough review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under some circumstances, deferred diagnostics were not
emitted for usages within a template function. This was
because the FunctionDecl associated with the diagnostic
was that of the template declaration, but at the point of
emitting the diagnostic, the FunctionDecl in the call chain
was that of the template instantiation.
Signed-off-by: Premanand M Rao premanand.m.rao@intel.com