[SYCL][L0] Add memory access hint to piKernelSetArgMemObj #9752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
Comment on lines
690
to
691
| case 0: | ||
| break; |
There was a problem hiding this comment.
what is being handled in this case?
There was a problem hiding this comment.
redundant code, removed 11aeaec
Comment on lines
+1741
to
+1743
| __SYCL_EXPORT pi_result piextKernelSetArgMemObj( | ||
| pi_kernel kernel, pi_uint32 arg_index, | ||
| const pi_mem_obj_property *arg_properties, const pi_mem *arg_value); |
There was a problem hiding this comment.
Please bump the major.minor PI version at the top of this file
There was a problem hiding this comment.
done 11aeaec
smaslov-intel
approved these changes
Jun 27, 2023
jandres742
reviewed
Jun 27, 2023
| @@ -682,9 +682,29 @@ UR_APIEXPORT ur_result_t UR_APICALL urKernelSetArgMemObj( | |||
|
|
|||
| ur_mem_handle_t_ *UrMem = ur_cast<ur_mem_handle_t_ *>(ArgValue); | |||
|
|
|||
| ur_mem_handle_t_::access_mode_t UrAccessMode = ur_mem_handle_t_::read_write; | |||
| if (Properties) { | |||
| assert(Properties->stype == | |||
There was a problem hiding this comment.
please remove this assert. That belongs to the UR loader validation layer.
There was a problem hiding this comment.
done 11aeaec
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
againull
approved these changes
Jun 28, 2023
veselypeta
pushed a commit
to veselypeta/llvm
that referenced
this pull request
Sep 21, 2023
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.