Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][ABI-break] Remove the workaround for release of auxiliary buffers #9914

Merged
merged 10 commits into from
Jul 10, 2023
Merged

[SYCL][ABI-break] Remove the workaround for release of auxiliary buffers #9914

merged 10 commits into from
Jul 10, 2023

Conversation

sergey-semenov
Copy link
Contributor

@sergey-semenov sergey-semenov commented Jun 15, 2023 •
edited
Loading

Remove the thread local variable workaround for deferred release of auxiliary resources by passing the required information from reduction headers.

@sergey-semenov
[SYCL] Remove the workaround for deferred release of auxiliary buffers
c201fb9 
This change does not break ABI boundary, but it does break backwards
compatibility since the library now requires new information from
headers.
@sergey-semenov sergey-semenov requested a review from a team as a code owner June 15, 2023 16:45
@sergey-semenov sergey-semenov temporarily deployed to aws June 15, 2023 17:27 — with GitHub Actions Inactive
@sergey-semenov sergey-semenov temporarily deployed to aws June 15, 2023 19:03 — with GitHub Actions Inactive
@sergey-semenov sergey-semenov temporarily deployed to aws June 16, 2023 15:07 — with GitHub Actions Inactive
@sergey-semenov sergey-semenov temporarily deployed to aws June 16, 2023 15:48 — with GitHub Actions Inactive
KseniyaTikhomirova
KseniyaTikhomirova reviewed Jun 22, 2023
View reviewed changes
Copy link
Contributor

@KseniyaTikhomirova KseniyaTikhomirova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

windows symbols update could be also needed

sycl/include/sycl/handler.hpp Outdated Show resolved Hide resolved
@sergey-semenov sergey-semenov changed the title [SYCL] Remove the workaround for deferred release of auxiliary buffers [SYCL][ABI-break] Remove the workaround for deferred release of auxiliary buffers Jul 4, 2023
@sergey-semenov sergey-semenov changed the title [SYCL][ABI-break] Remove the workaround for deferred release of auxiliary buffers [SYCL][ABI-break] Remove the workaround for release of auxiliary buffers Jul 4, 2023
@sergey-semenov sergey-semenov temporarily deployed to aws July 4, 2023 18:44 — with GitHub Actions Inactive
@sergey-semenov sergey-semenov temporarily deployed to aws July 4, 2023 19:22 — with GitHub Actions Inactive
@sergey-semenov sergey-semenov temporarily deployed to aws July 5, 2023 11:53 — with GitHub Actions Inactive
@sergey-semenov sergey-semenov temporarily deployed to aws July 5, 2023 12:31 — with GitHub Actions Inactive
@sergey-semenov
Copy link
Contributor Author

@KseniyaTikhomirova Could you please review this change?

KseniyaTikhomirova
KseniyaTikhomirova approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@KseniyaTikhomirova KseniyaTikhomirova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergey-semenov sergey-semenov merged commit fda9171 into intel:sycl Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KseniyaTikhomirova KseniyaTikhomirova KseniyaTikhomirova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergey-semenov @KseniyaTikhomirova