Skip to content
This repository has been archived by the owner on Jan 7, 2023. It is now read-only.

Expose more usage for FP16 and RGBA1010102 format #88

Merged
merged 2 commits into from
Sep 16, 2019
Merged

Expose more usage for FP16 and RGBA1010102 format #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a3f93c
Expose more usage for FP16 format
renchenglei Aug 16, 2019
07170df
Expose more usages for RGBA1010102 format
renchenglei Sep 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions cros_gralloc/gralloc1/cros_gralloc1_module.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,13 +390,6 @@ int32_t CrosGralloc1::allocate(struct cros_gralloc_buffer_descriptor *descriptor
descriptor->use_flags = usage;
bool supported = driver->is_supported(descriptor);

if(!supported && (descriptor->drm_format == DRM_FORMAT_ABGR2101010 ||
descriptor->drm_format == DRM_FORMAT_ABGR16161616F)){
descriptor->use_flags &= ~BO_USE_RENDERING;
descriptor->use_flags &= ~BO_USE_TEXTURE;
supported = driver->is_supported(descriptor);
}

if (!supported && (descriptor->consumer_usage & GRALLOC1_CONSUMER_USAGE_HWCOMPOSER)) {
descriptor->use_flags &= ~BO_USE_SCANOUT;
supported = driver->is_supported(descriptor);
Expand Down
9 changes: 5 additions & 4 deletions i915_private.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ static const uint32_t private_rgb24_formats[] = { DRM_FORMAT_RGB888, DRM_FORMAT_

static const uint32_t private_source_formats[] = { DRM_FORMAT_P010, DRM_FORMAT_NV12_Y_TILED_INTEL };

static const uint32_t private_rgba_format[] = { DRM_FORMAT_ABGR2101010, DRM_FORMAT_ABGR16161616F };

#if !defined(DRM_CAP_CURSOR_WIDTH)
#define DRM_CAP_CURSOR_WIDTH 0x8
#endif
Expand Down Expand Up @@ -109,8 +107,11 @@ int i915_private_add_combinations(struct driver *drv)
metadata.tiling = I915_TILING_NONE;
metadata.priority = 1;
metadata.modifier = DRM_FORMAT_MOD_NONE;
drv_add_combinations(drv, private_rgba_format, ARRAY_SIZE(private_rgba_format), &metadata,
BO_USE_SW_WRITE_OFTEN | BO_USE_SCANOUT);
drv_add_combination(drv, DRM_FORMAT_ABGR2101010, &metadata,
BO_USE_SCANOUT | BO_USE_TEXTURE |
BO_USE_RENDERING | BO_USE_SW_MASK);
drv_add_combination(drv, DRM_FORMAT_ABGR16161616F, &metadata,
BO_USE_SCANOUT | BO_USE_TEXTURE | BO_USE_RENDERING);

metadata.tiling = I915_TILING_Y;
metadata.priority = 3;
Expand Down