port_data: Use a separate socket for reading and writing #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The port code is ready to be used with two separate endpoints with different src_ip and dst_ip, but one common UDP socket was used for both of these endpoints. Added a separate fd for reading and writing, so enabling user having a separate source and destination IPs. Fixed a minor bug in setting the src_ip as a parameter.
|
Hi David, I guess they'd like to test in loopback so the two ports and two ips are needed. It's a more general way. In the tcp2_check.ttcnpp we can check that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I am proposing a small update to the ext port-data layer, especially useful if running the titan engine in a VM/docker where the external addresses/ports could be altered by NAT/forwarding...
src_ipas a parameter.