Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 1.x API #1323

Merged
merged 13 commits into from
Oct 19, 2023
Merged

Remove 1.x API #1323

merged 13 commits into from
Oct 19, 2023

Conversation

yiliu30
Copy link
Contributor

@yiliu30 yiliu30 commented Oct 13, 2023

Type of Change

API changed: Remove 1.x APIs

Description

The 1.x APIs will be removed in INC v2.4. To make it trackable, there will be serial PRs to remove it gradually.

Only keep the export-related API under neural_compressor/experimental.

├── experimental
│   ├── export
│   ├── __init__.py

TODO List

  • Update all experimental APIs caller (avoid from neural_compressor.experimental import xxx under neural_compressor)
  • Sperate the UTs for 1.x and 2.x, and remove all 1.x UTs.
  • Update the docs
  • Update CI Model-Test @chensuyue

Expected Behavior & Potential Risk

The from neural_compressor.experimental import xxx will become invalid.

How has this PR been tested?

Pre-CI

Dependency Change?

None

Signed-off-by: yiliu30 <yi4.liu@intel.com>
Signed-off-by: yiliu30 <yi4.liu@intel.com>
pre-commit-ci bot and others added 11 commits October 13, 2023 07:51
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Signed-off-by: yiliu30 <yi4.liu@intel.com>
@chensuyue chensuyue requested a review from YIYANGCAI October 19, 2023 01:38
@yiliu30 yiliu30 requested a review from XinyuYe-Intel October 19, 2023 01:40
@chensuyue chensuyue added this to the v2.4 milestone Oct 19, 2023
@yiliu30 yiliu30 merged commit ee617a4 into master Oct 19, 2023
46 checks passed
@yiliu30 yiliu30 deleted the ly/remove_1x branch October 19, 2023 03:19
bmyrcha pushed a commit that referenced this pull request Oct 24, 2023
* Update all experimental APIs caller
---------
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: bmyrcha <bartosz.myrcha@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants