Adding new quantileType types to mlir test #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sartil
force-pushed
the
Adding-quantile-lit-test
branch
from
e223181 to
66feaae
Compare
sartil
force-pushed
the
Adding-quantile-lit-test
branch
from
66feaae to
0924795
Compare
|
check-mlir result:
|
|
Minor test addition for quantileTypes i8, u8 and bf16, @hrotuna @andrey-golubev please review |
hrotuna
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing a minor problem with the printout of unsigned quantileType types like u8, due to a limitation in the type parser that only set the Unsigned enum value but not the Signed one.
Added check for quantileTypes i8, u8 and bf16 in mlir/test/Dialect/Quant/Bytecode/types.mlir
JIRA ticket
Related PR in NPU Compiler and/or OpenVINO repository with sub-module update
Other related tickets