-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
various operator fixes #830
Conversation
I removed Now it seems that sometimes something gets stuck: https://cloudnative-k8sci.southcentralus.cloudapp.azure.com/blue/organizations/jenkins/pmem-csi/detail/PR-830/1/tests Deleting the CR hangs and eventually times out. I saw that once also locally, but couldn't reproduce it. Any idea why it might get stuck? |
Nope, not related to changes in this PR. It also fails the same way in https://cloudnative-k8sci.southcentralus.cloudapp.azure.com/blue/organizations/jenkins/pmem-csi/detail/PR-825/6/tests |
The reals issue is with running the earlier test:
|
|
Various markup fields were treated as part of the field description. We don't want the API server to set defaults for us because then they become part of the API version which defines them. Instead, we want the flexibility to change the default over time when that makes sense.
Not all fields were getting copied. The test was incomplete and therefore didn't catch that mistake.
687ef3a
to
2a9c10f
Compare
out.Spec.Image = in.Spec.Image | ||
out.Spec.CACert = in.Spec.CACert | ||
out.Spec.PullPolicy = in.Spec.PullPolicy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pohly I googled about this missing conversions and came across about conversion-gen code generation tool, that generates the type conversion code as mentioned here. What do you think, shall we use that as a separate change or part of this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we use it, then in a separate PR.
I want to get into a stable state as quickly as possible again and using that tool may need further investigations and discussions.
This covers validation, defaulting and conversion.