Serial Peripheral Interface #148
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated shiftReg needed in spi
mkorbel1
reviewed
Jan 6, 2025
mkorbel1
reviewed
Jan 23, 2025
mkorbel1
requested changes
Jan 27, 2025
| final count = Counter.simple( | ||
| clk: intf.sclk, | ||
| enable: ~intf.csb, | ||
| reset: reset ?? Const(0, width: 1), |
There was a problem hiding this comment.
Hmm, if there's no reset, then maybe this whole counter shouldn't be here, actually. That would mean the done signal is dependent on a reset being provided.
| }); | ||
|
|
||
| // checking prev value at negedge | ||
| intf.sclk.negedge.listen((event) { |
There was a problem hiding this comment.
why is this check happening on negedge? I think you can just compare previousValue and value on sclk.posedge directly?
| // checking prev value at negedge | ||
| intf.sclk.negedge.listen((event) { | ||
| if (misoVal != null && misoVal != intf.miso.previousValue) { | ||
| logger.severe('Data on MISO is changing on posedge of sclk'); |
There was a problem hiding this comment.
Add a test that causes the checker to fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Adding Serial Peripheral Interface to ROHD-HCL. Contains BFM's and hardware gaskets for Main and Sub components in a SPI.
SPI is a commonly used interface and adding "drop in" components for SPI allows for easier use in designs.
Related Issue(s)
N/A
Testing
Testing included BFM unit tests, component unit tests, and BFM/ component cross testing.
Backwards-compatibility
No.
Documentation
Documentation added to doc/components/. Local API docs generated.