Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming definition #160

Merged
merged 77 commits into from
Jan 31, 2025
Merged

Naming definition #160

merged 77 commits into from
Jan 31, 2025

Conversation

desmonddak
Copy link
Contributor

Description & Motivation

Adding definitionName entries for components so that Verilog has fewer unique modules generated and names
are more meaningful.

Migrate to ROHD 0.6.1

Added NativeMultiplier wrapper for use in generating Verilog to use native multipliers.

Moved optional clocking into base Multiplier class.

Variable width optional output for FP Multiplier,

Related Issue(s)

None.

Testing

Inspected Verilog output of arithmetic blocks, ran logic synthesis to make sure the naming conventions were good.
Exhaustive tests for NativeMultiplier as well as FP Multiplier optional wide output.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No.

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

API documentation changes inline with code for new components and the new optional inputs for FP Mult.

ganewto and others added 30 commits January 7, 2025 15:16
@ganewto
extensive fp cleanup, support of Inf/NaN, addition of simple fp multi…
0b33234 
…plier
@ganewto
broken link
d70730f
@ganewto
dead link pub.dev
446f5cd
@ganewto
minor typo
ba178bc
@ganewto
use NativeAdder by default
8c3c15b
@desmonddak
general binary tree component and test
a283f76
@desmonddak
documentation and an experimental LogicArray binary tree
b185b1d
@ganewto
cleanup based on feedback in PR
e11e57e
@ganewto
second phase of cleanup based on feedback
f30787b
@ganewto
more doc of FP Values, signedshifter, code warning that stopped build
4b43929
@desmonddak
working binary tree
b9fdf61
@ganewto
markdown lint issues
6f15183
@desmonddak
updated code documentation
30b9eb3
@desmonddak
working reduction tree
a0760ea
@desmonddak
refactored into an iterative function
57a7f76
@desmonddak
preparted to merge iter into top class
d73020b
@desmonddak
merged ReductionTree module with internal recursion, documentation
1563fd8
@desmonddak
use floating_point.md from fpmult branch
343e45f
@desmonddak
don't use WaveDumper in regressions
7a10bfe
@desmonddak
remove binary_tree as reduction_tree covers
8593dcc
@desmonddak
reduction_tree in rohd_hcl, remove binary_tree
8db0a58
@desmonddak
forgot to saveall in vscode -- rohd_hcl.dart fix
e7a24f7
@desmonddak
Binary tree replaced bin reduction tree.
8fec4f9
@desmonddak
better use of dart maps
fac01f3
@desmonddak
use a record for capturing state
edac48f
@desmonddak
improve documentation with better examples
a366b84
@desmonddak
doc fix, more code neatening for clarity
8c10cae
@desmonddak
doc cleanup
aadd721
@desmonddak
more doc cleanup
9d02b42
@desmonddak
more documentation cleanup in code and markdown
60a4f03
@desmonddak
point to ROHD 0.6.1
892cf56
@desmonddak
naming fixes and doc updates in code
b22b9ac
@desmonddak
NativeMultiplier added and threaded through FloatingPointMultiplierSi…
c4fc0b4 
…mple
@desmonddak
widening fp mult
5e67ef3
@desmonddak
naming cleanups for fp mult and simple add
3e69e07
@desmonddak
more cleanup, fix confapp/pubspec
982a91a
@desmonddak
copyright updates and added some TODOs
c34e7b9
@desmonddak
cleanup Multiplier and MAC Apis
ac1daeb
@desmonddak
check for widening on fpmult, sweep width tests
ee8665b
@desmonddak
cleanup of extra clk addInputs
9cef6c7
@desmonddak
update pubspec, native adder naming internals
6982392
@desmonddak
confapp pubspec update
bf8b4f5
@desmonddak
a start on naming generated definitions
6b9d300
@desmonddak
fp and multiplier naming changes
8b7920b
@desmonddak
onescomplement and incr/decr naming
6482cbd
@desmonddak
signmagadder name
8e56dba
@desmonddak
naming in tree operations
b3d8977
@desmonddak
remove reduction tree for another branch
b175764
@desmonddak
fairly complete definition naming
4c2bdc3
@desmonddak
Merge branch 'main' into namingDefinition
0aaad9f
@desmonddak
md fixes (blank lines)
b5c3eff
@desmonddak
format issues with web merging
f637956
@desmonddak desmonddak requested a review from mkorbel1 January 30, 2025 14:57
mkorbel1
mkorbel1 reviewed Jan 31, 2025
View reviewed changes
lib/src/arithmetic/fixed_to_float.dart Show resolved Hide resolved
lib/src/arithmetic/float_to_fixed.dart Outdated Show resolved Hide resolved
lib/src/arbiters/mask_round_robin_arbiter.dart Outdated Show resolved Hide resolved
lib/src/arithmetic/floating_point/floating_point_multiplier.dart Show resolved Hide resolved
lib/src/edge_detector.dart Outdated Show resolved Hide resolved
lib/src/rotate.dart Outdated Show resolved Hide resolved
lib/src/shift_register.dart Outdated Show resolved Hide resolved
@desmonddak desmonddak merged commit 3302e0e into intel:main Jan 31, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkorbel1 mkorbel1 mkorbel1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@desmonddak @mkorbel1 @ganewto