Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ExternalSystemVerilogModule's argument from topModuleName to definitionName #169

Closed
mkorbel1 opened this issue Sep 28, 2022 · 0 comments · Fixed by #187
Closed

Rename ExternalSystemVerilogModule's argument from topModuleName to definitionName #169

mkorbel1 opened this issue Sep 28, 2022 · 0 comments · Fixed by #187
Assignees
@mkorbel1
Labels
enhancement New feature or request

Comments

@mkorbel1
Copy link
Contributor

Motivation

It's confusing to call it topModuleName since it's not really a "top", and its inconsistent with definitionName used on all other Modules.

Desired solution

Rename it from topModuleName to definitionName. This does break backwards compatibility, unfortunately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkorbel1 mkorbel1

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename topModuleName to definitionName in ExternalSystemVerilogModule mkorbel1/rohd
1 participant
@mkorbel1