Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue#7] Adding isIn() for <Logic>[], <int>[], <bool>[], <dynamic>[] #259

Merged
merged 6 commits into from
Feb 7, 2023
Merged

[issue#7] Adding isIn() for <Logic>[], <int>[], <bool>[], <dynamic>[] #259

merged 6 commits into from
Feb 7, 2023

Conversation

RPG-coder-intc
Copy link
Contributor

@RPG-coder-intc RPG-coder-intc commented Feb 7, 2023 •
edited
Loading

The Array can be a mix of Logic, LogicValue, int, bool & BigInt.
This function belongs to Logic Class

Description & Motivation

Inclusion of IsIn() function

[TODO]

  • Is the function results synthesized on hardware?
  • Test coverage logic_test

Related Issue(s)

For more details please refer to, ISSUE #7

Testing

Documentation

@RPG-coder-intc
Copy link
Contributor Author

RPG-coder-intc commented Feb 7, 2023 •
edited
Loading

Continuation of PR #195

mkorbel1
mkorbel1 requested changes Feb 7, 2023
View reviewed changes
lib/src/logic.dart Outdated Show resolved Hide resolved
test/bus_test.dart Outdated Show resolved Hide resolved
mkorbel1
mkorbel1 requested changes Feb 7, 2023
View reviewed changes
test/isin_bus_test.dart Outdated Show resolved Hide resolved
test/isin_bus_test.dart Outdated Show resolved Hide resolved
mkorbel1
mkorbel1 requested changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to nit-pick :)

test/isin_test.dart Outdated Show resolved Hide resolved
test/isin_test.dart Show resolved Hide resolved
test/isin_test.dart Outdated Show resolved Hide resolved
test/isin_test.dart Outdated Show resolved Hide resolved
mkorbel1
mkorbel1 approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@mkorbel1 mkorbel1 merged commit de39e7d into intel:main Feb 7, 2023
@mkorbel1 mkorbel1 linked an issue Feb 8, 2023 that may be closed by this pull request
Create an equalsAnyOf type of synthesizable function #7
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkorbel1 mkorbel1 mkorbel1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create an equalsAnyOf type of synthesizable function
2 participants
@RPG-coder-intc @mkorbel1