-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LogicStructure
and LogicArray
#375
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Adds both
LogicStructure
andLogicArray
implementations to ROHD. See new documentation for details on API and usage.It also adds a variety of bug fixes, both previously found and newly discovered.
LogicStructure
to groupLogic
s in a way that can be used likeLogic
#36, the main issue for this PR.LogicValue
s with negative 64-bit values would generate invalid SystemVerilog notation (with a-
sign).ConditionalGroup
, a singleConditional
that accepts a collection of otherConditional
s for grouping them together.LogicValue.of
which accepts adynamic
input and tries its best to build what you're looking for. AddsLogicValue.ofIterable
to replace the oldLogicValue.of
.oven_fsm.md
file during tests.Logic
and related content into a newsignals
directory.IterableRemovableQueue
to make code more readable.SignalRedrivenException
constructor to accept a list of signals instead of just a string.LogicConstructionException
type for failures in construction of a signal.SignalWidthMismtachException
type for failures in connecting two signals together, and updatedPortWidthMismatchException
.LogicValueConstructionException
type for failures when creating aLogicValue
getRange
,swizzle
,slice
, etc. that remove unnecessary module creation when there are 0-width or only 1 element.Logic
related toLogicStructure
s andLogicArray
s:isArrayMember
,structureName
,arrayIndex
,parentStructure
List
s non-growable for minor perf enhancementException
s toError
s (and updated Replace genericException
s with more specific or ROHD-related exceptions #105)Also opened some new issues:
LogicArray
s #377 tracking part-assign automation forLogicArray
sLogicArray
ports rohd-cosim#32 addingLogicArray
support to ROHD CosimRelated Issue(s)
Fix #36
Fix #254
Fix #311
Testing
Extensive new tests written and existing tests upgraded.
Backwards-compatibility
Yes, a variety of small changes.
mulAssign
anddivAssign
APIs have changed slightly.ConditionalAssign
now returnConditional
(e.g.<
operator forLogic
).Documentation
Yes, added new docs in the user guide.