Make conditional assign a little more optimistic with invalid values #459
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Previous changes made any invalid value on a conditional assignment turn the entire bus to
X
, which is very pessimistic, probably too much. Better would be to convert anyZ
bit toX
, but leave the valid bits alone. That's the main change in this PR.Also:
Logic
,Module
, etc.CustomSystemVerilog
SV generation.Related Issue(s)
N/A
Testing
Added new tests, plus existing tests cover a lot
Backwards-compatibility
No, but behavior will be slightly more optimistic now (closer to previous implementation).
Documentation
No