Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make conditional assign a little more optimistic with invalid values #459

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

mkorbel1
Copy link
Contributor

Description & Motivation

Previous changes made any invalid value on a conditional assignment turn the entire bus to X, which is very pessimistic, probably too much. Better would be to convert any Z bit to X, but leave the valid bits alone. That's the main change in this PR.

Also:

  • Fix some doc comments
  • Fix a missing link in CHANGELOG
  • Add some assertions to help catch SV generation issues in case users override built-in functionality from Logic, Module, etc.
  • Add a more interesting test on CustomSystemVerilog SV generation.

Related Issue(s)

N/A

Testing

Added new tests, plus existing tests cover a lot

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No, but behavior will be slightly more optimistic now (closer to previous implementation).

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No

@mkorbel1 mkorbel1 merged commit 7e01467 into intel:main Jan 18, 2024
2 checks passed
@mkorbel1 mkorbel1 deleted the cond_assign_optimism branch January 18, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant