Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(devtool): build devtool artifact and commit to other branch #461

Merged
merged 23 commits into from
Mar 8, 2024

Conversation

quekyj
Copy link
Contributor

@quekyj quekyj commented Feb 9, 2024

Description & Motivation

To test out the unreleased version of the devtool_extension, we can allow github action to commit the build artifact and modified the .gitignore. So, user can point to this package in pubspec.yaml via the use of:

rohd:
     git:
       url: https://github.com/quekyj/rohd.git
       ref: artifacts

Branch that have the artifact:

  • artifacts

Testing

Tested on fork.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

no

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No.

* chore: Add build artifact to artifact branch

* Fix: identation error on gh action

* Fix path

* Fix: Attempt to fix permission issue

* Fix: Syntax error

* Test with new branch

* Add permissions

* Add write permission to content

* Add git pull to get the latest changes

* pull from origin main

* Add git fetch origin

* Add force push

* remove redundance with

* use force instead
.github/workflows/general.yml Outdated Show resolved Hide resolved
.github/workflows/general.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

We should include information about this branch in the user guide section we write about the devtools extension

.github/workflows/build_devtool.yml Show resolved Hide resolved
@mkorbel1
Copy link
Contributor

mkorbel1 commented Feb 9, 2024

Were you able to get the extension running by pointing at the artifacts branch?

I tried adding this into a pubspec.yaml (not in the rohd package itself):

dependency_overrides:
  rohd:
    git:
      url: https://github.com/quekyj/rohd.git
      ref: artifacts

It looks like all the build artifacts are there in the downloaded dependency, but I don't see it showing up in the devtools?

@quekyj
Copy link
Contributor Author

quekyj commented Feb 14, 2024

Were you able to get the extension running by pointing at the artifacts branch?

I tried adding this into a pubspec.yaml (not in the rohd package itself):

dependency_overrides:
  rohd:
    git:
      url: https://github.com/quekyj/rohd.git
      ref: artifacts

It looks like all the build artifacts are there in the downloaded dependency, but I don't see it showing up in the devtools?

Yes, I can get it working. Are you using the beta version of flutter?

@mkorbel1
Copy link
Contributor

Yes, I can get it working. Are you using the beta version of flutter?

Really? I tried in WSL using latest Dart version:
Dart SDK version: 3.3.0 (stable) (None) on "linux_x64"

I don't see it showing up

Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thank you!

@mkorbel1 mkorbel1 merged commit c8d89d1 into intel:main Mar 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants