-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(devtool): build devtool artifact and commit to other branch #461
Conversation
* chore: Add build artifact to artifact branch * Fix: identation error on gh action * Fix path * Fix: Attempt to fix permission issue * Fix: Syntax error * Test with new branch * Add permissions * Add write permission to content * Add git pull to get the latest changes * pull from origin main * Add git fetch origin * Add force push * remove redundance with * use force instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
We should include information about this branch in the user guide section we write about the devtools extension
Were you able to get the extension running by pointing at the I tried adding this into a dependency_overrides:
rohd:
git:
url: https://github.com/quekyj/rohd.git
ref: artifacts It looks like all the build artifacts are there in the downloaded dependency, but I don't see it showing up in the devtools? |
Yes, I can get it working. Are you using the beta version of flutter? |
Really? I tried in WSL using latest Dart version: I don't see it showing up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! thank you!
Description & Motivation
To test out the unreleased version of the devtool_extension, we can allow github action to commit the build artifact and modified the .gitignore. So, user can point to this package in pubspec.yaml via the use of:
Branch that have the artifact:
Testing
Tested on fork.
Backwards-compatibility
no
Documentation
No.