Performance fixes: wrong collections and unmodifiable views causing inefficiencies #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
See #489 for the initial bug which started this PR.
This PR includes changes to support efficient iteration and search through collections in multiple APIs where incorrect usage of collections and unmodifiable views could cause severe performance issues for large numbers of elements.
Also, this adds an
UnmodifiableTraverseableCollectionViewto help support the use cases.Related Issue(s)
Fix #489
Testing
Module.subModules#489, but now finishes quicklyUnmodifiableTraverseableCollectionViewandTraverseableCollectionBackwards-compatibility
Only performance changes should be visible in existing APIs.
Documentation
No