Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestMathBitsXPU issues #683

Closed
2 tasks done
daisyden opened this issue Aug 2, 2024 · 3 comments
Closed
2 tasks done

TestMathBitsXPU issues #683

daisyden opened this issue Aug 2, 2024 · 3 comments
Assignees
Milestone

Comments

@daisyden
Copy link
Contributor

daisyden commented Aug 2, 2024

🐛 Describe the bug

  • accuracy issue of test_neg_view_nn_functional_rrelu_xpu_float64 - PASSED on
    torch 2.6.0a0+git64ccebd
    torch-xpu-ops 3b245e2

  • RuntimeError: value cannot be converted to type float without overflow
    TestMathBitsXPU has 2 cases with RuntimeError: value cannot be converted to type float without overflow - v2.6
    "test_conj_view_addbmm_xpu_complex64",
    "test_neg_conj_view_addbmm_xpu_complex128", - duplicated with [Evaluated] MKLDNN implementation of addbmm does not support complex and real data type #436

Versions

latest version

@daisyden daisyden added this to the PT2.6 milestone Aug 2, 2024
@daisyden daisyden self-assigned this Aug 2, 2024
@daisyden
Copy link
Contributor Author

test_ops.py

RuntimeError: value cannot be converted to type float without overflow

    "test_conj_view_addbmm_xpu_complex64",
    "test_neg_conj_view_addbmm_xpu_complex128",

@daisyden
Copy link
Contributor Author

no this case any more based on latest pytorch, test_neg_view_nn_functional_rrelu_xpu_float64, on db80b98ec460ca5b2fd84c1dfb6426925f64c8cc

@daisyden
Copy link
Contributor Author

daisyden commented Sep 19, 2024

For test_conj_view_addbmm_xpu_complex64, we got "RuntimeError: value cannot be converted to type float without overflow", it could because the addbmm implementation of mkldnn has explicit cast to float like "alpha.to()", when the alpha and beta are complex, it causes the error. {'beta': (1+2j), 'alpha': (2+3j)}. @ZhiweiYan-96 please help follow up.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants