Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Evaluated] TestMathBitsXPU issues #249

Closed
daisyden opened this issue May 16, 2024 · 7 comments
Closed

[Evaluated] TestMathBitsXPU issues #249

daisyden opened this issue May 16, 2024 · 7 comments
Assignees
Milestone

Comments

@daisyden
Copy link
Contributor

daisyden commented May 16, 2024

🐛 Describe the bug

  1. TestMathBitsXPU , RuntimeError: DispatchStub: unsupported device typexpu - Fixed

    "test_conj_view_conj_physical_xpu_complex64",
    "test_neg_conj_view_conj_physical_xpu_complex128",

In aten/src/ATen/native/DispatchStub.cpp function DispatchStubImpl::get_call_ptr() need to add a XPU path.
https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/native/DispatchStub.cpp#L94

image

  1. TestMathBitsXPU, RuntimeError: input tensor must have at least one element, but got input_sizes = [1, 0, 1] - 2.6
    "test_neg_view__refs_nn_functional_group_norm_xpu_float64",
    "test_neg_view_nn_functional_group_norm_xpu_float64",
    image

When the input_size has one dim be 0 it will got this error. While cpu backend would not. - Cuda also fail

  1. accuracy issue
    "test_neg_view_nn_functional_rrelu_xpu_float64", - rrelue not support
    "test_neg_view_nn_functional_dropout_xpu_float64", - skipped case also on cuda
    image

  2. RuntimeError: value cannot be converted to type float without overflow
    TestMathBitsXPU has 2 cases with RuntimeError: value cannot be converted to type float without overflow - v2.6

"test_conj_view_addbmm_xpu_complex64",
"test_neg_conj_view_addbmm_xpu_complex128",

image

However cpu backend can work:

image

Versions

Collecting environment information...
PyTorch version: 2.4.0a0+git470723f
Is debug build: False
CUDA used to build PyTorch: None
ROCM used to build PyTorch: N/A

OS: Ubuntu 22.04.3 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Clang version: 14.0.0-1ubuntu1.1
CMake version: version 3.26.4
Libc version: glibc-2.35

Python version: 3.10.14 (main, May 6 2024, 19:42:50) [GCC 11.2.0] (64-bit runtime)
Python platform: Linux-5.15.0-106-generic-x86_64-with-glibc2.35
Is CUDA available: False
CUDA runtime version: No CUDA
CUDA_MODULE_LOADING set to: N/A
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 52 bits physical, 57 bits virtual
Byte Order: Little Endian
CPU(s): 224
On-line CPU(s) list: 0-223
Vendor ID: GenuineIntel
Model name: Intel(R) Xeon(R) Platinum 8480+
CPU family: 6
Model: 143
Thread(s) per core: 2
Core(s) per socket: 56
Socket(s): 2
Stepping: 8
CPU max MHz: 3800.0000
CPU min MHz: 800.0000
BogoMIPS: 4000.00
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf tsc_known_freq pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cat_l2 cdp_l3 invpcid_single intel_ppin cdp_l2 ssbd mba ibrs ibpb stibp ibrs_enhanced tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid cqm rdt_a avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb intel_pt avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local split_lock_detect avx_vnni avx512_bf16 wbnoinvd dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req avx512vbmi umip pku ospke waitpkg avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg tme avx512_vpopcntdq la57 rdpid bus_lock_detect cldemote movdiri movdir64b enqcmd fsrm md_clear serialize tsxldtrk pconfig arch_lbr amx_bf16 avx512_fp16 amx_tile amx_int8 flush_l1d arch_capabilities
Virtualization: VT-x
L1d cache: 5.3 MiB (112 instances)
L1i cache: 3.5 MiB (112 instances)
L2 cache: 224 MiB (112 instances)
L3 cache: 210 MiB (2 instances)
NUMA node(s): 2
NUMA node0 CPU(s): 0-55,112-167
NUMA node1 CPU(s): 56-111,168-223
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Enhanced IBRS; IBPB conditional; RSB filling; PBRSB-eIBRS SW sequence; BHI BHI_DIS_S
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected

Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] optree==0.11.0
[pip3] torch==2.4.0a0+git470723f
[conda] mkl-include 2024.1.0 intel_691 intel
[conda] mkl-static 2024.1.0 intel_691 intel
[conda] numpy 1.26.4 pypi_0 pypi
[conda] optree 0.11.0 pypi_0 pypi
[conda] torch 2.4.0a0+git470723f pypi_0 pypi

@daisyden daisyden changed the title The conj_physical inplace_variant does not support xpu device TestMathBitsXPU issues May 16, 2024
@fengyuan14 fengyuan14 changed the title TestMathBitsXPU issues [To Evaluate] TestMathBitsXPU issues May 16, 2024
@daisyden
Copy link
Contributor Author

To reproduce use PR#243
cd torch-xpu-ops/test/xpu
timeout 10000 python run_test_with_skip.py

@chunhuanMeng
Copy link
Contributor

#293

@fengyuan14
Copy link
Contributor

  • oneDNN issues. 1) value cannot be converted to type float without overflow. 2) Double and complex datatype matmul is not supported in oneDNN. 3) could not create a primitive descriptor for a deconvolution forward propagation primitive. @ZhiweiYan-96
  • CPU fallback failures. group_norm, rrelu. @xytintel

@fengyuan14 fengyuan14 modified the milestones: PT2.4, PT2.5 May 23, 2024
@fengyuan14 fengyuan14 changed the title [To Evaluate] TestMathBitsXPU issues [Evaluated] TestMathBitsXPU issues May 23, 2024
github-merge-queue bot pushed a commit that referenced this issue May 23, 2024
1. "conj_physical_" has not fallen back to cpu,so have the runtime error
"unsupported device typexpu“
test_conj_view_conj_physical_xpu_complex64 ,after fallback, cpu
conj_physical vs cpu conj_physical_(inplace) ,failed skip
test_neg_conj_view_conj_physical_xpu_complex128 ,after fallback, pass
    but this op is not the target operator we commit. so both skip.
2. cpu fallback issue
    test_neg_view__refs_nn_functional_group_norm_xpu_float64,skip
    test_neg_view_nn_functional_group_norm_xpu_float64,skip
3. cpu fallback issue and cuda failed too
test_neg_view_nn_functional_rrelu_xpu_float64 ,fallback to cpu,execute
the cpu version,failed,skip
test_neg_view_nn_functional_dropout_xpu_float64, cuda skip,reproduce the
case in cuda,failed too.skip
4. onednn issue
    test_conj_view_addbmm_xpu_complex64,skip
    test_neg_conj_view_addbmm_xpu_complex128,skip
    
    #249
fengyuan14 pushed a commit that referenced this issue May 23, 2024
1. "conj_physical_" has not fallen back to cpu,so have the runtime error
"unsupported device typexpu“
test_conj_view_conj_physical_xpu_complex64 ,after fallback, cpu
conj_physical vs cpu conj_physical_(inplace) ,failed skip
test_neg_conj_view_conj_physical_xpu_complex128 ,after fallback, pass
    but this op is not the target operator we commit. so both skip.
2. cpu fallback issue
    test_neg_view__refs_nn_functional_group_norm_xpu_float64,skip
    test_neg_view_nn_functional_group_norm_xpu_float64,skip
3. cpu fallback issue and cuda failed too
test_neg_view_nn_functional_rrelu_xpu_float64 ,fallback to cpu,execute
the cpu version,failed,skip
test_neg_view_nn_functional_dropout_xpu_float64, cuda skip,reproduce the
case in cuda,failed too.skip
4. onednn issue
    test_conj_view_addbmm_xpu_complex64,skip
    test_neg_conj_view_addbmm_xpu_complex128,skip
    
    #249
@chuanqi129
Copy link
Contributor

@chunhuanMeng please help to double check whether this issue can be closed

@chuanqi129
Copy link
Contributor

1 2 may same issue, Zhiwei has a PR to fix it. 3 should be fixed, need @daisyden double check, 4 postpone to 2.6

@chunhuanMeng
Copy link
Contributor

hi @chuanqi129 . For 3,case 1 fails because we haven't implemented rrelu, so it fallbacks to cpu ,and fails .for case 2, cuda fails too. I have done the analysis in #293

@daisyden
Copy link
Contributor Author

daisyden commented Aug 2, 2024

submitted issue for 3 and 4 at #683.

@daisyden daisyden closed this as completed Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants