Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sample] Fix numeric overflow when calculate softmax. #326

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

Duyi-Wang
Copy link
Contributor

No description provided.

@Duyi-Wang Duyi-Wang requested review from marvin-Yu and abenmao April 18, 2024 07:52
@pujiang2018
Copy link
Contributor

need to firstly minus max element to avoid NaN issues.

@Duyi-Wang Duyi-Wang requested a review from pujiang2018 April 18, 2024 08:29
@pujiang2018 pujiang2018 merged commit fdcb843 into intel:main Apr 18, 2024
1 check passed
@Duyi-Wang Duyi-Wang deleted the fix_overflow_in_sampling branch April 24, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants