[Model] Add Qwen2 model. #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the differences between Qwen1.0 vs Qwen 2.0? |
pujiang2018
reviewed
Apr 20, 2024
| RmsNorm finalLN; | ||
| }; | ||
|
|
||
| REGISTER_DECODER(Qwen2LLM, qwen2, float) |
There was a problem hiding this comment.
What's the error when put such macro to cpp file?
There was a problem hiding this comment.
What's the error when put such macro to cpp file?
Putting in a CPP file won't trigger the execution of this macro, it confused me. It instantiates a static object of a registrar.
There was a problem hiding this comment.
not the scope of this PR.
changqi1
reviewed
Apr 22, 2024
| "initializer_range": 0.02, | ||
| "intermediate_size": 2816, | ||
| "max_position_embeddings": 32768, | ||
| "max_window_layers": 21, |
There was a problem hiding this comment.
what is the meaning for max_window_layers?
If Qwen2.0 have no difference w/ LLama2. Do we need to inherit from LLama2? |
marvin-Yu
force-pushed
the
model/add_qwen2
branch
from
1cb752f to
e368bf6
Compare
marvin-Yu
force-pushed
the
model/add_qwen2
branch
from
e368bf6 to
89cf4dc
Compare
changqi1
approved these changes
Apr 23, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.