-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should path be an array? #3
Comments
Right now, for us, it's more convenient that .toJSON() is compatible to the json patch spec, which adopts json pointer strings rather than arrays: https://tools.ietf.org/html/rfc6902 Will talk about it, perhaps could be an options to the diff function. |
You may prefer this fork: https://github.com/tgriesser/immutable-diff |
nice! perhaps we could eventually have a single code base, and an API to support both return types |
Use an empty array instead of / for the root.
I find it pointless to concat and stringify the path, because if one wants to use it (eg. in a
getIn
call), it has to be parsed. What's the point of having it as string? Yes I do some pattern matching now, using regular expressions, but even that would be faster and more convenient if path would be an array of actual keys.The text was updated successfully, but these errors were encountered: