Deprecated JSON RPC - added deprecation warning

intelsdi-x · Oct 24, 2016 · 908767e · 908767e
1 parent dbbb1ae
commit 908767e
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/control/available_plugin.go b/control/available_plugin.go
@@ -101,6 +101,11 @@ func newAvailablePlugin(resp plugin.Response, emitter gomit.Emitter, ep executab
 	case plugin.CollectorPluginType:
 		switch resp.Meta.RPCType {
 		case plugin.JSONRPC:
+			log.WithFields(log.Fields{
+				"_module":     "control-aplugin",
+				"_block":      "newAvailablePlugin",
+				"plugin_name": ap.name,
+			}).Warning("This plugin is using a deprecated JSON RPC protocol. Find more information here: https://github.com/intelsdi-x/snap/issues/1296 ")
 			c, e := client.NewCollectorHttpJSONRPCClient(listenURL, DefaultClientTimeout, resp.PublicKey, !resp.Meta.Unsecure)
 			if e != nil {
 				return nil, errors.New("error while creating client connection: " + e.Error())

diff --git a/control/plugin/client/httpjsonrpc.go → ...l/plugin/client/httpjsonrpc_deprecated.go b/control/plugin/client/httpjsonrpc.go → ...l/plugin/client/httpjsonrpc_deprecated.go
@@ -1,3 +1,8 @@
+/*          **  DEPRECATED  **
+For more information, see our deprecation notice
+on Github: https://github.com/intelsdi-x/snap/issues/1296
+*/
+
 /*
 http://www.apache.org/licenses/LICENSE-2.0.txt
 

diff --git a/control/plugin/client/httpjsonrpc_test.go → ...gin/client/httpjsonrpc_deprecated_test.go b/control/plugin/client/httpjsonrpc_test.go → ...gin/client/httpjsonrpc_deprecated_test.go
@@ -1,3 +1,8 @@
+/*          **  DEPRECATED  **
+For more information, see our deprecation notice
+on Github: https://github.com/intelsdi-x/snap/issues/1296
+*/
+
 /*
 http://www.apache.org/licenses/LICENSE-2.0.txt