Changed keyNode types to use embedded types

control/plugin/cpolicy/tree.go

@@ -140,18 +140,18 @@ func (c *ConfigPolicy) Get(ns []string) *ConfigPolicyNode {
 }
 
 type keyNode struct {
-	Key  []string
-	Node *ConfigPolicyNode
+	Key []string
+	*ConfigPolicyNode
 }
 
 func (c *ConfigPolicy) GetAll() []keyNode {
 
 	ret := make([]keyNode, 0)
 	for _, node := range c.config.GetAll() {
 		key := node.Key
-		switch t := node.N.(type) {
+		switch t := node.Node.(type) {
 		case *ConfigPolicyNode:
-			ret = append(ret, keyNode{Key: key, Node: t})
+			ret = append(ret, keyNode{Key: key, ConfigPolicyNode: t})
 		}
 	}
 	return ret

control/plugin/rpc/plugin.go

@@ -27,7 +27,7 @@ func NewGetConfigPolicyReply(policy *cpolicy.ConfigPolicy) (*GetConfigPolicyRepl
 	for _, node := range policy.GetAll() {
 		key := strings.Join(node.Key, ".")
 
-		for _, rule := range node.Node.RulesAsTable() {
+		for _, rule := range node.RulesAsTable() {
 			switch rule.Type {
 			case cpolicy.BoolType:
 				r := &BoolRule{

control/plugin_manager.go

@@ -362,8 +362,7 @@ func (p *pluginManager) LoadPlugin(details *pluginDetails, emitter gomit.Emitter
 		if lPlugin.ConfigPolicy != nil {
 			// Get plugin config defaults
 			defaults := cdata.NewNode()
-			for _, kn := range lPlugin.ConfigPolicy.GetAll() {
-				cpolicy := kn.Node
+			for _, cpolicy := range lPlugin.ConfigPolicy.GetAll() {
 				_, errs := cpolicy.AddDefaults(defaults.Table())
 				if len(errs.Errors()) > 0 {
 					for _, err := range errs.Errors() {

pkg/ctree/tree.go

@@ -116,7 +116,7 @@ func (c *ConfigTree) Add(ns []string, inNode Node) {
 
 type keyNode struct {
 	Key []string
-	N   Node
+	Node
 }
 
 func (c *ConfigTree) GetAll() []keyNode {
@@ -137,8 +137,8 @@ func (c *ConfigTree) getAll(node *node, key []string, res *[]keyNode) []keyNode
 		}
 		if node.Node != nil {
 			k := keyNode{
-				Key: key,
-				N:   node.Node,
+				Key:  key,
+				Node: node.Node,
 			}
 			*res = append(*res, k)
 		}