Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Commit

Permalink
Updates plugin and client packages
Browse files Browse the repository at this point in the history
Updates plugin package. Removes grpc server actions from the package
since this is being moved to a new plugin-lib repo.

Updates client package to use new function prototypes of passing metric
all the way through a workflow instead of bytes through process/publish.

For native/gob, the encoding/decoding now happens in the client. This is
done because the concept of contentType was removed form the framework
but we still want to support existing plugins. Doing this in the client
allows existing plugins to interact with plugins written using any other
langauge lib.

Updates proto definitions, including adding some types that were
previously referenced from common. This was done to allow plugin-libs
written in other languages to only require one proto file to generate
from, reducing complexity for the plugin-lib authors at the cost of some
duplication.
  • Loading branch information
IRCody committed Aug 17, 2016
1 parent d971fba commit f7767bd
Show file tree
Hide file tree
Showing 14 changed files with 976 additions and 1,146 deletions.
4 changes: 2 additions & 2 deletions control/plugin/client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@ type PluginCollectorClient interface {
// PluginProcessorClient A client providing processor specific plugin method calls.
type PluginProcessorClient interface {
PluginClient
Process(contentType string, content []byte, config map[string]ctypes.ConfigValue) (string, []byte, error)
Process([]core.Metric, map[string]ctypes.ConfigValue) ([]core.Metric, error)
}

// PluginPublisherClient A client providing publishing specific plugin method calls.
type PluginPublisherClient interface {
PluginClient
Publish(contentType string, content []byte, config map[string]ctypes.ConfigValue) error
Publish([]core.Metric, map[string]ctypes.ConfigValue) error
}
Loading

0 comments on commit f7767bd

Please sign in to comment.