Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Command-line parameters should be consistently applied when creating tasks #1126

Closed
tjmcs opened this issue Aug 5, 2016 · 1 comment · Fixed by #1127
Closed

Command-line parameters should be consistently applied when creating tasks #1126

tjmcs opened this issue Aug 5, 2016 · 1 comment · Fixed by #1127

Comments

@tjmcs
Copy link
Contributor

tjmcs commented Aug 5, 2016

When creating tasks, the current version of snapctl only uses the command-line parameters associated with the snapctl task create ... command when a task is being created using a workflow manifest. In the case where a task is being created using a task manifest, any command-line parameters that are included in the snapctl task create ... command are silently ignored.

It would be much less confusing to the user if these command-line parameters were consistently applied for both of these use cases (creating a task using either a task manifest or a workflow manifest), with any command-line parameters that are set by the user when creating a task using a task manifest overriding the corresponding definitions for these parameters in the task manifest.

tjmcs pushed a commit to tjmcs/snap that referenced this issue Aug 5, 2016
@tjmcs
Copy link
Contributor Author

tjmcs commented Aug 5, 2016

It should be noted that this issue is a more generic statement of Issue #285, which simply requests that users be allowed to override the task name from a task manifest; a PR that resolves this issue would also resolve Issue #285.

tjmcs pushed a commit to tjmcs/snap that referenced this issue Aug 8, 2016
tjmcs pushed a commit to tjmcs/snap that referenced this issue Aug 8, 2016
tjmcs pushed a commit to tjmcs/snap that referenced this issue Aug 8, 2016
tjmcs pushed a commit to tjmcs/snap that referenced this issue Aug 8, 2016
tjmcs pushed a commit to tjmcs/snap that referenced this issue Aug 8, 2016
tjmcs pushed a commit to tjmcs/snap that referenced this issue Aug 10, 2016
tjmcs pushed a commit to tjmcs/snap that referenced this issue Aug 10, 2016
tjmcs pushed a commit to tjmcs/snap that referenced this issue Aug 10, 2016
tjmcs pushed a commit to tjmcs/snap that referenced this issue Aug 10, 2016
tjmcs pushed a commit to tjmcs/snap that referenced this issue Aug 11, 2016
tjmcs pushed a commit to tjmcs/snap that referenced this issue Aug 11, 2016
tjmcs pushed a commit to tjmcs/snap that referenced this issue Aug 11, 2016
tjmcs pushed a commit to tjmcs/snap that referenced this issue Aug 12, 2016
tjmcs pushed a commit to tjmcs/snap that referenced this issue Aug 12, 2016
tjmcs pushed a commit to tjmcs/snap that referenced this issue Aug 12, 2016
tjmcs pushed a commit to tjmcs/snap that referenced this issue Aug 13, 2016
tjmcs pushed a commit to tjmcs/snap that referenced this issue Aug 15, 2016
IRCody added a commit that referenced this issue Aug 15, 2016
Fixes #1113 & #1131 and Resolves #1126; improves task creation process in `snapctl`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants