This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
Remove usage of dot separator in config tree #1240
Comments
IRCody
added a commit
to IRCody/snap
that referenced
this issue
Sep 30, 2016
Instead of returning a map[string]*configPolicyNode Getall() now returns a []keyNode where keyNode contains the []string key and the *configPolicyNode. Adds repeated string keys for Policy proto types and implements backwards compatible logic to work with a '.' delimitted string if using a plugin compiled against older client-libs. Removed freeze from ctree since it's no longer used. Also removed references to it.
IRCody
added a commit
that referenced
this issue
Oct 7, 2016
Fixes #1240 -- Removes dot separator from ctree
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In ctree a
.separator is used when calling GetAll(). This forces.'s to not be accepted in some cases inside a metric namespace. This seems like an unnecessary so I think it should be removed.I think the main place this is used is in plugin_manager.go and the grpc for both snap's side and the client libs. Changes here will result in changes being needed on the client-libs also but it would be nice if the change was backward compatible.
The text was updated successfully, but these errors were encountered: