Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Do not execute binaries directly from the auto-load path #1502

Closed
jcooklin opened this issue Jan 31, 2017 · 2 comments
Closed

Do not execute binaries directly from the auto-load path #1502

jcooklin opened this issue Jan 31, 2017 · 2 comments

Comments

@jcooklin
Copy link
Collaborator

Currently, plugins loaded by the snaptel cli via 'snaptel plugin load file_name' are copied to a temporary directory before they are executed. Plugins placed in the auto-load directory are loaded directly from that filepath without going through this process. This prevents plugin files from getting updated when Snap is running since they are in use. We would like snap plugins to behave the same whether they are loaded via the autoloader or snaptel plugin load cli.

@jtlisi
Copy link
Contributor

jtlisi commented Jan 31, 2017

#1494 is something that relates very closely to this. If the temporary directory could default to /opt/snap/plugins/tmp/ or something along those lines that would be better than the linux default tmp directory

@jcooklin
Copy link
Collaborator Author

jcooklin commented Jan 31, 2017

@jtlisi: agreed. @rashmigottipati is currently working on #1494.

rashmigottipati added a commit to rashmigottipati/snap that referenced this issue Feb 24, 2017
- plugins are run from tmp dir on all code paths
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants