Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Fix plugin load timeout in LoadPlugin and startPlugin #1618

Closed
rashmigottipati opened this issue Apr 28, 2017 · 0 comments
Closed

Fix plugin load timeout in LoadPlugin and startPlugin #1618

rashmigottipati opened this issue Apr 28, 2017 · 0 comments

Comments

@rashmigottipati
Copy link
Contributor

rashmigottipati commented Apr 28, 2017

Currently, the global option PluginLoadTimeout is implemented such that we wait till we receive the plugin's response (which is the preamble) or we timeout. There could be cases where we are able to get to the point where we receive the plugin response but the plugin load is still unsuccessful. This requires us to change the implementation of timeout such that we wait until we receive a loaded plugin in plugin_manager.go. So, we need to block until receiving a loaded plugin or timeout expiry.
Similarly, in startPlugin in runner.go, we need to wait until receiving a channel's response which either has an available plugin or error, and then timeout.

Also, PluginLoadTimeout is hardcoded in control/runner.go. This makes it inconsistent with other code paths as the timeout value is being read from config in those. We need to make it more consistent and have all the code paths read the timeout value from the config as opposed to hardcoding the value.

@rashmigottipati rashmigottipati self-assigned this Apr 28, 2017
rashmigottipati added a commit to rashmigottipati/snap that referenced this issue Apr 28, 2017
rashmigottipati added a commit to rashmigottipati/snap that referenced this issue May 1, 2017
rashmigottipati added a commit to rashmigottipati/snap that referenced this issue May 10, 2017
- Global option plugin load timeout should be read from config on
  all code paths
rashmigottipati added a commit to rashmigottipati/snap that referenced this issue May 10, 2017
- Fix plugin load timeout in LoadPlugin and startPlugin
  by blocking until receiving plugin's response or timeout expiry
rashmigottipati added a commit to rashmigottipati/snap that referenced this issue May 10, 2017
- Fix plugin load timeout in LoadPlugin and startPlugin
  by blocking until receiving plugin's response or timeout expiry
@rashmigottipati rashmigottipati changed the title Plugin load timeout should be read from config on all code paths Fix plugin load timeout in LoadPlugin and startPlugin May 10, 2017
rashmigottipati added a commit to rashmigottipati/snap that referenced this issue May 10, 2017
- Fix plugin load timeout in LoadPlugin and startPlugin
  by blocking until receiving plugin's response or timeout expiry
rashmigottipati added a commit to rashmigottipati/snap that referenced this issue May 11, 2017
- Fix plugin load timeout in LoadPlugin and startPlugin
  by blocking until receiving plugin's response or timeout expiry
rashmigottipati added a commit to rashmigottipati/snap that referenced this issue May 12, 2017
- Fix plugin load timeout in LoadPlugin and startPlugin
  by blocking until receiving plugin's response or timeout expiry
rashmigottipati added a commit to rashmigottipati/snap that referenced this issue May 12, 2017
- Fix plugin load timeout in LoadPlugin and startPlugin
  by blocking until receiving plugin's response or timeout expiry
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant