Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Propose to merge 'snap-plugin-collector-csvreader' into intelsdi-x repo #1721

Closed
cuongquay opened this issue Aug 24, 2017 · 3 comments
Closed

Comments

@cuongquay
Copy link
Contributor

Sometime we need to stub or reload some metrics from CSV files that require having a plugin to collect the csv's column as a single metric. I wrote one plugin to do so at https://github.com/cuongquay/snap-plugin-collector-csvreader.

I would love to be a contributor of your repository. This is a brilliant telemetry collector project as far as I can see,

@andrzej-k
Copy link
Contributor

Hey @cuongquay Great work on CVS reader plugin! Two comments if I may:

@cuongquay
Copy link
Contributor Author

Thank you for correcting me. I have just updated the copyright headers of source files and adding the metadata.yaml file into this project. Can you review it and tell me if there is any missing?

@andrzej-k
Copy link
Contributor

This looks good. Please go ahead and create PR adding your plugin to https://github.com/intelsdi-x/snap/blob/master/docs/plugins.yml. Thanks!

cuongquay added a commit to cuongquay/snap that referenced this issue Aug 30, 2017
Fixes intelsdi-x#1721

Summary of changes:

Adding csvreader as a collector plugin
Read CSV column as metric
Testing done:

Tested with single and multiple column
andrzej-k added a commit that referenced this issue Aug 30, 2017
Fix issue #1721 about snap-plugin--csvreader
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants