This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
*schedulerWorkflow.BindPluginContentType() returns an error that's never checked #768
Comments
geauxvirtual
added a commit
that referenced
this issue
Mar 28, 2016
Fix #768: Return and check error from *schedulerWorkflow.BindPluginContentType() method
IzabellaRaulin
pushed a commit
to IzabellaRaulin/snap
that referenced
this issue
Mar 29, 2016
…ndPluginContentType() method
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In scheduler/scheduler.go line 189, *schedulerWorkflow.BindPluginContentType() is called, but the err variable set in this call is never checked.
https://github.com/intelsdi-x/snap/blob/master/scheduler/scheduler.go#L189
In scheduler/workflow.go, *schedulerWorkflow.BindPluginContentType() calls an internal method bindPluginContentType(), but then directly returns nil instead of any error from bindPluginContentType().
https://github.com/intelsdi-x/snap/blob/master/scheduler/workflow.go#L233-L236
In bindPluginContentType(), when a publisher is included with a process node, bindPluginContentType() is called for the publish nodes (and any other process nodes), but any error from this call is never caught and returned.
https://github.com/intelsdi-x/snap/blob/master/scheduler/workflow.go#L274
The text was updated successfully, but these errors were encountered: