Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Tasks running distributed workflow do not stop, error 10 times, then disable #987

Closed
geauxvirtual opened this issue Jun 11, 2016 · 1 comment · Fixed by #992
Closed

Tasks running distributed workflow do not stop, error 10 times, then disable #987

geauxvirtual opened this issue Jun 11, 2016 · 1 comment · Fixed by #992

Comments

@geauxvirtual
Copy link
Contributor

When trying to stop a task that is executing a distributed workflow, snapctl reports an error when trying to stop the task No plugins found. The task will eventually show as disabled when listing tasks via snapctl.

screen shot 2016-06-10 at 5 20 45 pm

Node A (described below) shows the following errors in the log file when a task is attempted to be stopped. The task will try to execute 10 times following the stop command, failing each time and then becoming disabled.

screen shot 2016-06-10 at 5 19 07 pm

Setup:
Node A:

  • Running the task
  • Loaded mock1, mock2, and processor plugins

Node B:

  • Loaded publisher plugin

Task being run

{
    "version": 1,
    "schedule": {
        "type": "simple",
        "interval": "1s"
    },
    "workflow": {
        "collect": {
            "metrics": {
                "/intel/mock/foo": {},
                "/intel/mock/bar": {},
                "/intel/mock/*/baz": {}
            },
            "config": {
                "/intel/mock": {
                    "name": "root",
                    "password": "secret"
                }
            },
            "process": [
                {
                    "plugin_name": "passthru",
                    "process": null,
                    "publish": [
                        {
                            "plugin_name": "file",
                            "target": "192.168.242.139:10082",
                            "config": {
                                "file": "/tmp/snap_published_mock_file.log"
                            }
                        }
                    ]
                }
            ]
        }
    }
}
IRCody added a commit to IRCody/snap that referenced this issue Jun 13, 2016
Adds check for metrics during unsubscribe. This avoids an incorrect
error message about missing plugins for nodes that have no collectors
running.
@IRCody
Copy link
Contributor

IRCody commented Jun 13, 2016

@geauxvirtual: Thanks for finding this. The root cause seems to be during unsubscribe we always checked for metrics to unsubscribe (even if none were present). I added a PR to address this issue by only going through the step of checking for metrics/collector plugins if at least 1 is present.

IRCody added a commit that referenced this issue Jun 22, 2016
Fixes #987: Adds check for metrics during unsubscribe
IRCody added a commit to IRCody/snap that referenced this issue Jun 23, 2016
Adds check for metrics during unsubscribe. This avoids an incorrect
error message about missing plugins for nodes that have no collectors
running.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants